Bug IISH#14: maxsize is an array of zero elements when empty. Do not use a null comparison.

Lucien van Wouw · Lucien van Wouw · commit 7dcbda4d4a6b · 2017-10-19T18:32:07.000+02:00
diff --git a/oai2-plugin/src/main/java/org/socialhistoryservices/api/oai/OAIRequestHandler.java b/oai2-plugin/src/main/java/org/socialhistoryservices/api/oai/OAIRequestHandler.java
@@ -325,7 +325,7 @@ public void init(NamedList args) {
         }
 
         final List maxrecords = args.getAll("maxrecords");
-        if (maxrecords == null)
+        if (maxrecords.size() == 0)
             Parameters.setParam(args, "maxrecords_default", 200);
         else {
             SolrParams p = SolrParams.toSolrParams((NamedList) maxrecords.get(0));

Original file line number	Diff line number	Diff line change
`@@ -325,7 +325,7 @@ public void init(NamedList args) {`
`325`	`325`	`}`
`326`	`326`
`327`	`327`	`final List maxrecords = args.getAll("maxrecords");`
`328`		`- if (maxrecords == null)`
	`328`	`+ if (maxrecords.size() == 0)`
`329`	`329`	`Parameters.setParam(args, "maxrecords_default", 200);`
`330`	`330`	`else {`
`331`	`331`	`SolrParams p = SolrParams.toSolrParams((NamedList) maxrecords.get(0));`