make requested changes

Author: Jiatao7

backend/api/endpoints/command.py

@@ -35,10 +35,8 @@ def create_command(payload: CommandRequest, db: Session = Depends(get_db)):
     # Find number of commands in database
     query = select(Command)
     items = db.exec(query).all()
-    num_commands = len(items)
 
     command = Command (
-        id=1+num_commands,
         command_type=payload.command_type,
         params=payload.params,
     )
@@ -59,14 +57,13 @@ def delete_command(id: int, db: Session = Depends(get_db)):
     @return returns the list of commands after deleting the item
     """
     # TODO:(Member) Implement this endpoint
-    try:
-        query = select(Command).where(Command.id == id)
-        command = db.exec(query).one()
+    command = db.get(Command, id)
+    if command:
         db.delete(command)
         db.commit()
 
         query2 = select(Command).where(Command.id != id)
         items = db.exec(query2).all()
         return {"data": items}
-    except:
+    else:
         raise HTTPException(status_code=404, detail="Item does not exist")

backend/api/middlewares/logger_middleware.py

@@ -3,7 +3,7 @@
 from fastapi import Request, Response
 from starlette.middleware.base import BaseHTTPMiddleware
 
-from ...utils.logging import logger
+from backend.utils.logging import logger
 
 import time
 import json

backend/data/data_models.py

@@ -33,18 +33,18 @@ def validate_params_format(self):
         The format of the comma seperated values is "data1,data2" so no spaces between data and the commas.
         """
         # TODO: (Member) Implement this method
-        if (self.params == None and self.format == None):
+        if self.params is None and self.format is None:
             return self
-        elif (self.params == None or self.format == None):
-            raise(ValueError)
-        elif (len(self.params.split(",")) == len(self.format.split(","))):
+        elif self.params is None or self.format is None:
+            raise ValueError()
+        elif len(self.params.split(",")) == len(self.format.split(",")):
             return self
         else:
-            raise(ValueError)
+            raise ValueError()
 
 class Command(BaseSQLModel, table=True):
     """
-    An instance of a MainCommand.
+    An instance off a MainCommand.
     This table holds the data related to actual commands sent from the ground station up to the OBC.
     """