Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use <button> instead of <p><a>...<a/><p/> #1092

Closed
Tracked by #1110
hmpf opened this issue Dec 17, 2024 · 0 comments · Fixed by #1118
Closed
Tracked by #1110

Use <button> instead of <p><a>...<a/><p/> #1092

hmpf opened this issue Dec 17, 2024 · 0 comments · Fixed by #1118
Assignees
Labels
polish Nice to have

Comments

@hmpf
Copy link
Contributor

hmpf commented Dec 17, 2024

All occurrences of <p><a>...<a/><p/> should be changed to <button> either in this PR or in a separate issue because since it is better for accessibility. I also don't see a reason to not programatically render button when it looks like one.

Originally posted by @podliashanyk in #1087 (comment)

@hmpf hmpf mentioned this issue Jan 9, 2025
10 tasks
@lunkwill42 lunkwill42 self-assigned this Jan 9, 2025
@lunkwill42 lunkwill42 added the polish Nice to have label Jan 9, 2025
lunkwill42 added a commit that referenced this issue Jan 9, 2025
hmpf pushed a commit that referenced this issue Jan 9, 2025
@johannaengland johannaengland linked a pull request Jan 14, 2025 that will close this issue
@hmpf hmpf closed this as completed in 3e0ffad Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Nice to have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants