Skip to content

Commit 009d1fb

Browse files
committed
fix: adding suggestions from PR, turning ListView into VisualElement and adjusting UIMessageFeed.cs accordingly
1 parent 79e8592 commit 009d1fb

File tree

4 files changed

+201
-214
lines changed

4 files changed

+201
-214
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,3 @@
1-
.message-feed {
2-
width: 480%;
3-
height: 250px;
4-
border-radius: 5px;
5-
border: solid 1px rgb(204, 204, 204);
6-
padding: 10px;
7-
position: absolute;
8-
left: 64px;
9-
top: 500px;
10-
}
11-
12-
.message-item {
13-
font-size: 14px;
14-
color: rgb(51, 51, 51);
15-
padding: 8px;
16-
margin-bottom: 8px;
17-
border-radius: 4px;
18-
word-wrap: break-word;
19-
width: 480px;
20-
height: 50px;
21-
position: absolute;
22-
top: 500px;
23-
left: 64px;
24-
}
25-
261
.message {
272
color: rgb(255, 193, 21);
283
font-size: 14px;
@@ -48,35 +23,21 @@
4823
transition-timing-function: ease-in-out-back, ease-in;
4924
transition-duration: 0.5s, 1s;
5025
position: relative;
51-
overflow: scroll;
26+
overflow: hidden;
5227
flex-direction: column;
5328
}
5429

5530
.messageBoxMove {
5631
translate: 0 0 0;
5732
}
5833

59-
.message:hover {
60-
left: 10px;
61-
}
62-
6334
.messageBoxFadeOut {
6435
opacity: 0;
6536
}
6637

67-
#messageList {
38+
#messageFeed {
6839
flex-direction: column;
6940
position: absolute;
7041
top: -537px;
71-
}
72-
73-
/* since we are using absolute position with a list view in this case
74-
we need to make sure to override the default scroll view behaviors */
75-
#messageList .unity-scroll-view__content-viewport {
76-
overflow: hidden;
77-
}
78-
79-
#messageList .unity-scroll-view__content-container {
80-
overflow: hidden;
81-
}
82-
42+
left: 30px;
43+
}
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
<engine:UXML xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:engine="UnityEngine.UIElements" xmlns:editor="UnityEditor.UIElements" noNamespaceSchemaLocation="../../../../../UIElementsSchema/UIElements.xsd" editor-extension-mode="False">
22
<Style src="project://database/Assets/Prefabs/UI/UIToolkit/USS/MessageFeed.uss?fileID=7433441132597879392&amp;guid=daa8504d262853748b8d7c2a377261a3&amp;type=3#MessageFeed" />
3-
<engine:VisualElement name="messageFeed" style="flex-grow: 1;">
4-
<engine:ListView item-template="project://database/Assets/Prefabs/UI/UIToolkit/UXML/MessageItem.uxml?fileID=9197481963319205126&amp;guid=67ec44aea0b0f484c86c6489932cfcad&amp;type=3#MessageItem" name="messageList" virtualization-method="DynamicHeight" binding-source-selection-mode="AutoAssign" class="messageList" />
5-
</engine:VisualElement>
3+
<engine:VisualElement name="messageFeed" picking-mode="Ignore" />
64
</engine:UXML>

Assets/Prefabs/UI/UIToolkit/UXML/PostGameUICanvas.uxml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@
1010
<engine:Button text="return to menu" name="menuBtn" class="menuButton" style="left: 32%; top: 75%; position: absolute;" />
1111
<engine:Button text="Waiting on host &#10;to play again" name="waitOnHostBtn" class="menuButton" style="position: absolute; top: 60%; left: 32%;" />
1212
</engine:VisualElement>
13-
<engine:Instance template="MessageFeed" />
13+
<engine:Instance template="MessageFeed" name="messageList" />
1414
</engine:UXML>

0 commit comments

Comments
 (0)