fix(networked-var): Fixes networked var sync when object is not spawned

This also makes object spawning faster

Fixes: #210

Author: TwoTenPvP

MLAPI-Editor/NetworkingManagerEditor.cs

@@ -27,7 +27,7 @@ public class NetworkingManagerEditor : Editor
     private SerializedProperty maxReceiveEventsPerTickRateProperty;
     private SerializedProperty sendTickrateProperty;
     private SerializedProperty eventTickrateProperty;
-    private SerializedProperty maxBehaviourUpdatesPerTickProperty;
+    private SerializedProperty maxObjectUpdatesPerTickProperty;
     private SerializedProperty clientConnectionBufferTimeoutProperty;
     private SerializedProperty connectionApprovalProperty;
     private SerializedProperty secondsHistoryProperty;
@@ -100,7 +100,7 @@ private void Init()
         maxReceiveEventsPerTickRateProperty = networkConfigProperty.FindPropertyRelative("MaxReceiveEventsPerTickRate");
         sendTickrateProperty = networkConfigProperty.FindPropertyRelative("SendTickrate");
         eventTickrateProperty = networkConfigProperty.FindPropertyRelative("EventTickrate");
-        maxBehaviourUpdatesPerTickProperty = networkConfigProperty.FindPropertyRelative("MaxBehaviourUpdatesPerTick");
+        maxObjectUpdatesPerTickProperty = networkConfigProperty.FindPropertyRelative("MaxObjectUpdatesPerTick");
         clientConnectionBufferTimeoutProperty = networkConfigProperty.FindPropertyRelative("ClientConnectionBufferTimeout");
         connectionApprovalProperty = networkConfigProperty.FindPropertyRelative("ConnectionApproval");
         secondsHistoryProperty = networkConfigProperty.FindPropertyRelative("SecondsHistory");
@@ -133,7 +133,7 @@ private void CheckNullProperties()
         maxReceiveEventsPerTickRateProperty = networkConfigProperty.FindPropertyRelative("MaxReceiveEventsPerTickRate");
         sendTickrateProperty = networkConfigProperty.FindPropertyRelative("SendTickrate");
         eventTickrateProperty = networkConfigProperty.FindPropertyRelative("EventTickrate");
-        maxBehaviourUpdatesPerTickProperty = networkConfigProperty.FindPropertyRelative("MaxBehaviourUpdatesPerTick");
+        maxObjectUpdatesPerTickProperty = networkConfigProperty.FindPropertyRelative("MaxObjectUpdatesPerTick");
         clientConnectionBufferTimeoutProperty = networkConfigProperty.FindPropertyRelative("ClientConnectionBufferTimeout");
         connectionApprovalProperty = networkConfigProperty.FindPropertyRelative("ConnectionApproval");
         secondsHistoryProperty = networkConfigProperty.FindPropertyRelative("SecondsHistory");
@@ -278,7 +278,7 @@ public override void OnInspectorGUI()
 
             using (new EditorGUI.DisabledScope(!networkingManager.NetworkConfig.EnableNetworkedVar))
             {
-                EditorGUILayout.PropertyField(maxBehaviourUpdatesPerTickProperty);
+                EditorGUILayout.PropertyField(maxObjectUpdatesPerTickProperty);
             }            
 
             EditorGUILayout.LabelField("Connection", EditorStyles.boldLabel);

MLAPI/Data/NetworkConfig.cs

@@ -7,6 +7,7 @@
 using MLAPI.Transports;
 using BitStream = MLAPI.Serialization.BitStream;
 using System.Security.Cryptography.X509Certificates;
+using UnityEngine.Serialization;
 
 namespace MLAPI.Configuration
 {
@@ -62,12 +63,13 @@ public class NetworkConfig
         [Tooltip("The amount of times per second the internal event loop will run. This includes for example SyncedVar checking and LagCompensation tracking")]
         public int EventTickrate = 64;
         /// <summary>
-        /// The maximum amount of NetworkedBehaviour's to process per tick.
+        /// The maximum amount of NetworkedObject's to process per tick.
         /// This is useful to prevent the MLAPI from hanging a frame
         /// Set this to less than or equal to 0 for unlimited
         /// </summary>
-        [Tooltip("The maximum amount of NetworkedBehaviour SyncedVars to process per Event tick. This is to prevent freezing")]
-        public int MaxBehaviourUpdatesPerTick = -1;
+        [FormerlySerializedAs("MaxBehaviourUpdatesPerTick")] 
+        [Tooltip("The maximum amount of NetworkedObject SyncedVars to process per Event tick. This is to prevent freezing")]
+        public int MaxObjectUpdatesPerTick = -1;
         /// <summary>
         /// The amount of seconds to wait for handshake to complete before timing out a client
         /// </summary>

MLAPI/MonoBehaviours/Core/NetworkedBehaviour.cs

@@ -118,8 +118,7 @@ private void OnEnable()
         {
             if (_networkedObject == null)
                 _networkedObject = GetComponentInParent<NetworkedObject>();
-
-            NetworkedObject.NetworkedBehaviours.Add(this);
+            
             OnEnabled();
         }
 
@@ -130,7 +129,6 @@ private void OnDisable()
 
         private void OnDestroy()
         {
-            NetworkedObject.NetworkedBehaviours.Remove(this); // O(n)
             CachedClientRpcs.Remove(this);
             CachedServerRpcs.Remove(this);
             OnDestroyed();

MLAPI/MonoBehaviours/Core/NetworkedObject.cs

@@ -17,8 +17,6 @@ namespace MLAPI
     [AddComponentMenu("MLAPI/NetworkedObject", -99)]
     public sealed class NetworkedObject : MonoBehaviour
     {
-        internal static readonly List<NetworkedBehaviour> NetworkedBehaviours = new List<NetworkedBehaviour>();
-
         private void OnValidate()
         {
             if (string.IsNullOrEmpty(PrefabHashGenerator))
@@ -384,18 +382,21 @@ internal List<NetworkedBehaviour> childNetworkedBehaviours
             }
         }
 
-        private static int _lastProcessedBehaviour = 0;
+        private static int _lastProcessedObject = 0;
         internal static void NetworkedBehaviourUpdate()
         {
-            int amountToProcess = NetworkingManager.Singleton.NetworkConfig.MaxBehaviourUpdatesPerTick <= 0 ? NetworkedBehaviours.Count : Mathf.Max(NetworkingManager.Singleton.NetworkConfig.MaxBehaviourUpdatesPerTick, NetworkedBehaviours.Count);
+            int amountToProcess = NetworkingManager.Singleton.NetworkConfig.MaxObjectUpdatesPerTick <= 0 ? SpawnManager.SpawnedObjectsList.Count : Mathf.Max(NetworkingManager.Singleton.NetworkConfig.MaxObjectUpdatesPerTick, SpawnManager.SpawnedObjectsList.Count);
 
             for (int i = 0; i < amountToProcess; i++)
             {
-                if (_lastProcessedBehaviour >= NetworkedBehaviours.Count)
-                    _lastProcessedBehaviour = 0;
-
-                NetworkedBehaviours[_lastProcessedBehaviour].NetworkedVarUpdate();
-                _lastProcessedBehaviour++;
+                if (_lastProcessedObject >= SpawnManager.SpawnedObjectsList.Count)
+                    _lastProcessedObject = 0;
+                
+                // Sync all vars
+                for (int j = 0; j < SpawnManager.SpawnedObjectsList[_lastProcessedObject].childNetworkedBehaviours.Count; j++)
+                    SpawnManager.SpawnedObjectsList[_lastProcessedObject].childNetworkedBehaviours[j].NetworkedVarUpdate();
+                
+                _lastProcessedObject++;
             }
         }