change nicknames

Author: simonLeary42

test/functional/PIBecomeApproveTest.php

@@ -80,7 +80,7 @@ public function testApprovePI()
     public function testReinstateDefunctGroup()
     {
         global $USER, $SSO, $LDAP, $SQL, $MAILER, $WEBHOOK;
-        $this->switchUser("PreviousOwnerOfDefunctPIGroup");
+        $this->switchUser("ResurrectedOwnerOfDefunctPIGroup");
         $this->assertFalse($USER->isPI());
         $user = $USER;
         $pi_group = $USER->getPIGroup();

test/functional/RegisterUserTest.php

@@ -63,7 +63,7 @@ public function testResurrectNoHauntedGroup()
     public function testResurrectWithHauntedGroup()
     {
         global $USER;
-        $this->switchUser("GhostPI");
+        $this->switchUser("GhostOwnerOfDefunctPIGroup");
         $this->assertTrue($USER->getFlag(UserFlag::GHOST));
         $this->assertFalse($USER->isPI());
         try {

test/phpunit-bootstrap.php

@@ -221,8 +221,8 @@ class UnityWebPortalTestCase extends TestCase
         "CustomMapped555" => "user2002_org998_test",
         "Ghost" => "user7_org1_test",
         "GhostNotPI" => "user7_org1_test",
-        "GhostPI" => "user9_org3_test",
-        "PreviousOwnerOfDefunctPIGroup" => "user10_org1_test",
+        "GhostOwnerOfDefunctPIGroup" => "user9_org3_test",
+        "ResurrectedOwnerOfDefunctPIGroup" => "user10_org1_test",
         "HasNoSshKeys" => "user3_org1_test",
         "HasOneSshKey" => "user5_org2_test",
         "IdleLocked" => "user6_org1_test",
@@ -274,7 +274,7 @@ private function validateUser(string $nickname)
             case "Ghost":
                 $this->assertTrue($USER->getFlag(UserFlag::GHOST));
                 break;
-            case "GhostPI":
+            case "GhostOwnerOfDefunctPIGroup":
                 $this->assertTrue($USER->getFlag(UserFlag::GHOST));
                 $this->assertTrue($USER->getPIGroup()->exists());
                 $this->assertTrue($USER->getPIGroup()->getIsDefunct());
@@ -283,7 +283,7 @@ private function validateUser(string $nickname)
                 $this->assertTrue($USER->getFlag(UserFlag::GHOST));
                 $this->assertFalse($USER->getPIGroup()->exists());
                 break;
-            case "PreviousOwnerOfDefunctPIGroup":
+            case "ResurrectedOwnerOfDefunctPIGroup":
                 $this->assertTrue($USER->exists());
                 $this->assertFalse($USER->getFlag(UserFlag::GHOST));
                 $this->assertFalse($USER->isPI());