"tos" input should never be unspecified (#431)

simonLeary42 · web-flow · commit 0eb2ea1b8ab9 · 2025-12-19T16:16:52.000-05:00
diff --git a/webroot/panel/account.php b/webroot/panel/account.php
@@ -72,7 +72,7 @@
             if ($SQL->requestExists($USER->uid, UnitySQL::REQUEST_BECOME_PI)) {
                 UnityHTTPD::badRequest("already requested to be PI");
             }
-            if (!isset($_POST["tos"]) || $_POST["tos"] != "agree") {
+            if ($_POST["tos"] != "agree") {
                 UnityHTTPD::badRequest("user did not agree to terms of service");
             }
             $USER->getPIGroup()->requestGroup($SEND_PIMESG_TO_ADMINS);
diff --git a/webroot/panel/groups.php b/webroot/panel/groups.php
@@ -30,7 +30,7 @@
         switch ($_POST["form_type"]) {
             case "addPIform":
                 $pi_account = $getPIGroupFromPost();
-                if (!isset($_POST["tos"]) || $_POST["tos"] != "agree") {
+                if ($_POST["tos"] != "agree") {
                     UnityHTTPD::badRequest("user did not agree to terms of service");
                 }
                 if ($pi_account->exists()) {

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@`
`72`	`72`	`if ($SQL->requestExists($USER->uid, UnitySQL::REQUEST_BECOME_PI)) {`
`73`	`73`	`UnityHTTPD::badRequest("already requested to be PI");`
`74`	`74`	`}`
`75`		`- if (!isset($_POST["tos"]) \|\| $_POST["tos"] != "agree") {`
	`75`	`+ if ($_POST["tos"] != "agree") {`
`76`	`76`	`UnityHTTPD::badRequest("user did not agree to terms of service");`
`77`	`77`	`}`
`78`	`78`	`$USER->getPIGroup()->requestGroup($SEND_PIMESG_TO_ADMINS);`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@`
`30`	`30`	`switch ($_POST["form_type"]) {`
`31`	`31`	`case "addPIform":`
`32`	`32`	`$pi_account = $getPIGroupFromPost();`
`33`		`- if (!isset($_POST["tos"]) \|\| $_POST["tos"] != "agree") {`
	`33`	`+ if ($_POST["tos"] != "agree") {`
`34`	`34`	`UnityHTTPD::badRequest("user did not agree to terms of service");`
`35`	`35`	`}`
`36`	`36`	`if ($pi_account->exists()) {`