-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bid model + Create Bid + Active landing page bid response #99
Conversation
vikinatora
commented
Oct 19, 2021
- Add bid model (may change in the future)
- Add temp create bid functionality which will be used until the scraping functionality is done
- Upgrade the active landing page response to feature bids and other active auctions info
Let me know what you think guys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some quick comments. I will take a closer look tomorrow morning when I get back to work
cc @johnkcr take a look at this PR to get familiar with other parts of the app |
Also cc: @taskudis can also start getting to know the codebase |
@alexandrumatei36 We need to think of a way to change how the auction is queried or the link of the page in the FE as I just got into a bug where after you change your display name in the profile page, the link to the auction doesn't get updated and it can't find the auction when you open the landing page Updating all the auction links on profile change is one way but I don' think it's optimal |
@vikinatora The auction link doesn't have to contain the user display name. It should be stored separately and the auction url computed piece by piece |
…upgrade bidders response
|