chore: tested different failure vectors for email input

Author: Utilitycoder

Cargo.lock

@@ -28,10 +28,13 @@ secrecy = { version = "0.8", features = ["serde"] }
 tracing-actix-web = "0.5"
 sqlx = { version = "0.5.7", default-features = false, features = ["offline", "runtime-actix-rustls", "macros", "postgres", "uuid", "chrono", "migrate"] }
 unicode-segmentation = "1"
+validator = "0.16.0"
+fake = "2.6.1"
 
 [dev-dependencies]
 reqwest = "0.11.18"
 once_cell = "1"
+claim = "0.5"
 
 [profile.release]
 strip = true

Cargo.toml

@@ -3,4 +3,5 @@ mod subscriber_email;
 mod subscriber_name;
 
 pub use new_subscriber::NewSubscriber;
+pub use subscriber_email::SubscriberEmail;
 pub use subscriber_name::SubscriberName;

src/domain/mod.rs

@@ -1 +1,71 @@
+use validator::validate_email;
 
+#[derive(Debug, PartialEq)]
+pub struct SubscriberEmail(String);
+
+impl SubscriberEmail {
+    pub fn parse(s: String) -> Result<SubscriberEmail, String> {
+        match validate_email(&s) {
+            true => Ok(Self(s)),
+            false => Err(format!("`{}` is not a valid email address.", s)),
+        }
+    }
+}
+
+impl AsRef<str> for SubscriberEmail {
+    fn as_ref(&self) -> &str {
+        &self.0
+    }
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use claim::{assert_err, assert_ok};
+    use fake::faker::internet::en::SafeEmail;
+    use fake::Fake;
+
+    #[test]
+    fn empty_string_is_rejected() {
+        let email = "".to_string();
+        assert_err!(SubscriberEmail::parse(email));
+    }
+
+    #[test]
+    fn whitespace_only_string_is_rejected() {
+        let email = "   ".to_string();
+        assert_err!(SubscriberEmail::parse(email));
+    }
+
+    #[test]
+    fn email_missing_at_symbol_is_rejected() {
+        let email = "lawal.gmail.com".to_string();
+        assert_err!(SubscriberEmail::parse(email));
+    }
+
+    #[test]
+    fn email_missing_subject_is_rejected() {
+        let email = "@gmail.com".to_string();
+        assert_err!(SubscriberEmail::parse(email));
+    }
+
+    #[test]
+    fn valid_email_is_parsed_successfully() {
+        let email = "[email protected]".to_string();
+        assert_ok!(SubscriberEmail::parse(email));
+    }
+
+    #[test]
+    fn email_with_double_at_symbol_is_rejected() {
+        let email = "lawal@@gmail.com".to_string();
+        assert_err!(SubscriberEmail::parse(email));
+    }
+
+    #[test]
+    fn valid_emails_are_parsed_successfully() {
+        let email = SafeEmail().fake();
+        println!("{}", email);
+        assert_ok!(SubscriberEmail::parse(email));
+    }
+
+}

src/domain/subscriber_email.rs

@@ -172,10 +172,10 @@ async fn subscribe_returns_a_400_when_fields_are_present_but_empty() {
             .expect("Failed to execute request.");
         // Assert
         assert_eq!(
-            200,
+            400,
             response.status().as_u16(),
             // Additional customised error message on test failure
-            "The API did not return a 200 OK when the payload was {}.",
+            "The API did not return a 400 bad request when the payload was {}.",
             error_message
         );
     }