chore: updated CI

Author: Utilitycoder

Diff for: .github/workflows/general.yml

@@ -1,59 +1,82 @@
+# The name of your workflow. GitHub displays the names of your workflows on your repository's "Actions" tab
 name: Rust
 
-on:
-  # NB: this differs from the book's project!
-  # These settings allow us to run this specific CI pipeline for PRs against
-  # this specific branch (a.k.a. book chapter).
-  push:
-    branches:
-      - main
-  pull_request:
-    types: [ opened, synchronize, reopened ]
-    branches:
-      - main
+on: [push, pull_request]
 
 env:
   CARGO_TERM_COLOR: always
   SQLX_VERSION: 0.6.2
   SQLX_FEATURES: "rustls,postgres"
 
+# A workflow run is made up of one or more jobs, which run in parallel by default
+# Each job runs in a runner environment specified by runs-on
 jobs:
+  # Unique identifier of our job (`job_id`)
   test:
+    # Sets the name `Test` for the job, which is displayed in the GitHub UI
     name: Test
+    # Containers must run in Linux based operating systems
     runs-on: ubuntu-latest
+    # Service containers to run with the `test` container job
     services:
+      # Label used to access the service container
       postgres:
-        image: postgres:14
+        # Docker Hub image
+        image: postgres:13.1
+        # Set environment variables for the service container
         env:
           POSTGRES_USER: postgres
-          POSTGRES_PASSWORD: password
+          POSTGRES_PASSWORD: postgres
           POSTGRES_DB: postgres
+        # Set health checks to wait until the service is ready
+        options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
+        # Map service container ports to the host ports
         ports:
           - 5432:5432
       redis:
         image: redis:7
         ports:
           - 6379:6379
+
     steps:
-      - uses: actions/checkout@v3
-      - uses: dtolnay/rust-toolchain@stable
+        # Downloads a copy of the code in your repository before running CI tests
+      - name: Check out repository code
+        # The uses keyword specifies that this step will run v3 of the actions/checkout action. 
+        # This is an action that checks out your repository onto the runner, allowing you to run scripts or other actions against your code (such as build and test tools).
+        # You should use the checkout action any time your workflow will run against the repository's code.
+        uses: actions/checkout@v3
+
+        # This GitHub Action installs a Rust toolchain using rustup. It is designed for one-line concise usage and good defaults.
+      - name: Install the Rust toolchain
+        uses: dtolnay/rust-toolchain@stable
+
+        # This GitHub Action caches the Rust toolchain between workflow runs. It is designed for one-line concise usage and good defaults.
       - uses: Swatinem/rust-cache@v2
         with:
+          # An additional cache key that is added alongside the automatic `job`-based cache key and can be used to further differentiate jobs. default: empty
           key: sqlx-${{ env.SQLX_VERSION }}
+
       - name: Install sqlx-cli
         run:
             cargo install sqlx-cli
             --version=${{ env.SQLX_VERSION }}
             --features ${{ env.SQLX_FEATURES }}
             --no-default-features
             --locked
+            # The --locked flag can be used to force Cargo to use the packaged Cargo.lock file if it is available. 
+            # This may be useful for ensuring reproducible builds, to use the exact same set of dependencies that were available when the package was published. 
+            # It may also be useful if a newer version of a dependency is published that no longer builds on your system, or has other problems
+  
+      - name: Install postgresql-client
+        run: sudo apt-get update && sudo apt-get install postgresql-client -y
+
       - name: Migrate database
-        run: |
-          sudo apt-get install libpq-dev -y
-          SKIP_DOCKER=true ./scripts/init_db.sh
+        run: SKIP_DOCKER=true ./scripts/init_db.sh
+
       - name: Check sqlx-data.json is up-to-date
         run: |
-          cargo sqlx prepare --check -- --bin zero2prod
+          cargo sqlx prepare --check -- --bin robust-rust
+
       - name: Run tests
         run: cargo test
 
@@ -68,6 +91,7 @@ jobs:
       - name: Enforce formatting
         run: cargo fmt --check
 
+  # `clippy` container job
   clippy:
     name: Clippy
     runs-on: ubuntu-latest
@@ -95,13 +119,14 @@ jobs:
             --features ${{ env.SQLX_FEATURES }}
             --no-default-features
             --locked
+      - name: Install postgresql-client
+        run: sudo apt-get update && sudo apt-get install postgresql-client -y
       - name: Migrate database
-        run: |
-          sudo apt-get install libpq-dev -y
-          SKIP_DOCKER=true ./scripts/init_db.sh
+        run: SKIP_DOCKER=true ./scripts/init_db.sh
       - name: Linting
         run: cargo clippy -- -D warnings
 
+  # `coverage` container job
   coverage:
     name: Code coverage
     runs-on: ubuntu-latest
@@ -122,13 +147,11 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v3
       - uses: dtolnay/rust-toolchain@stable
-      - name: Install libpq
+      - name: Install postgresql-client
         run: sudo apt-get update && sudo apt-get install postgresql-client -y
       - uses: Swatinem/rust-cache@v2
         with:
           key: sqlx-${{ env.SQLX_VERSION }}
-      - name: Install tarpaulin
-        run: cargo install cargo-tarpaulin
       - name: Install sqlx-cli
         run:
           cargo install sqlx-cli
@@ -139,4 +162,4 @@ jobs:
       - name: Migrate database
         run: SKIP_DOCKER=true ./scripts/init_db.sh
       - name: Generate code coverage
-        run: cargo tarpaulin --verbose --workspace
+        run: cargo install cargo-tarpaulin && cargo tarpaulin --verbose --workspace

Diff for: src/routes/admin/newsletters/post.rs

@@ -78,7 +78,7 @@ fn success_message() -> FlashMessage {
 
 #[tracing::instrument(skip_all)]
 async fn insert_newsletter_issue(
-    transaction:  &mut Transaction<'_, Postgres>,
+    transaction: &mut Transaction<'_, Postgres>,
     title: &str,
     text_content: &str,
     html_content: &str,