Merge pull request #511 from ValeevGroup/evaleev/fixup/tensor-interface-assignment

evaleev · web-flow · commit 1803cd6ed020 · 2025-03-19T06:18:16.000-04:00
`TensorInterface::operator=`: check value_type, not numeric_type
diff --git a/src/TiledArray/tensor/tensor_interface.h b/src/TiledArray/tensor/tensor_interface.h
@@ -194,7 +194,7 @@ class TensorInterface {
   template <typename T1, typename std::enable_if<detail::is_nested_tensor<
                              T1>::value>::type* = nullptr>
   TensorInterface_& operator=(const T1& other) {
-    if constexpr (std::is_same_v<numeric_type, numeric_t<T1>>) {
+    if constexpr (std::is_same_v<value_type, value_t<T1>>) {
       TA_ASSERT(data_ != other.data());
     }
 

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ class TensorInterface {`
`194`	`194`	`template <typename T1, typename std::enable_if<detail::is_nested_tensor<`
`195`	`195`	`T1>::value>::type* = nullptr>`
`196`	`196`	`TensorInterface_& operator=(const T1& other) {`
`197`		`- if constexpr (std::is_same_v<numeric_type, numeric_t<T1>>) {`
	`197`	`+ if constexpr (std::is_same_v<value_type, value_t<T1>>) {`
`198`	`198`	`TA_ASSERT(data_ != other.data());`
`199`	`199`	`}`
`200`	`200`