Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: support for redis sentinel #155

Closed
wiese opened this issue May 28, 2024 · 2 comments · Fixed by #156
Closed

feature request: support for redis sentinel #155

wiese opened this issue May 28, 2024 · 2 comments · Fixed by #156
Assignees
@Venatum
Labels
enhancement New feature or request released

Comments

@wiese
Copy link

wiese commented May 28, 2024 •
edited
Loading

Thank you for providing this docker image. We like bull-board and the docker image is very convenient for us.

We run redis with sentinel. Currently we get away with pointing bull board to connect to one of the redis instances but this is brittle and unintuitive.

As bull-board uses ioredis under the hood, which supports sentinel, is it at all thinkable to extend the config of bull-board-docker to also support configuring sentinel instead of a single host?

What are your thoughts? Would you be open for a pull request?
@wiese
Copy link
Author

wiese commented May 28, 2024

Also posted as Deadly0#27.

sfranke pushed a commit to sfranke/bull-board-docker that referenced this issue May 28, 2024
@sfioki
feat: adds support for sentinel
6f97b06 
ticket: Venatum#155

These changes add necessary changes for a sentinel configuration. This
allows the users to connect via a redis sentinel rather than a single
redis instance.
@sfranke sfranke mentioned this issue May 28, 2024
Merged
3 tasks
@Venatum Venatum self-assigned this Jun 3, 2024
@Venatum Venatum added the enhancement New feature or request label Jun 3, 2024
Venatum added a commit that referenced this issue Jun 24, 2024
@sfranke @sfioki @Venatum
feat: adds support for sentinel (#156)
aa6d74b 
ticket: #155

These changes add necessary changes for a sentinel configuration. This
allows the users to connect via a redis sentinel rather than a single
redis instance.

Co-authored-by: Sebastian Franke <[email protected]>
Co-authored-by: Vincent Le Quec <[email protected]>
@Venatum Venatum mentioned this issue Jun 24, 2024
Merged
3 tasks
Venatum added a commit that referenced this issue Aug 7, 2024
@Venatum @sfranke @sfioki
feat: adds support for sentinel (#156) (#168)
221c040 
* feat: adds support for sentinel (#156)

ticket: #155

These changes add necessary changes for a sentinel configuration. This
allows the users to connect via a redis sentinel rather than a single
redis instance.

Co-authored-by: Sebastian Franke <[email protected]>
Co-authored-by: Vincent Le Quec <[email protected]>

* docs: Setup some examples

* docs: Try to use sentinel mode

* docs: WIP... [ci skip]

* docs(sentinel): Add more examples

---------

Co-authored-by: sfranke <[email protected]>
Co-authored-by: Sebastian Franke <[email protected]>
@Venatum
Copy link
Owner

Venatum commented Aug 7, 2024

It's now available 🎉
v1.5.0

@Venatum Venatum closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Venatum Venatum

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adds support for sentinel sfranke/bull-board-docker
2 participants
@wiese @Venatum