Skip to content

Commit 09545f2

Browse files
committed
Remove leak displayed by profiler in RSS button display logic
This was not really a leak, because the closure was released after 200ms at most, but to make the profiler happy, we can use weak self in the closure. Cherry-pick of commit 3909cbc Co-authored-by: Tassilo Karge <[email protected]>
1 parent ac87971 commit 09545f2

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Vienna/Sources/Main window/BrowserTab+RSSSource.swift

+4-4
Original file line numberDiff line numberDiff line change
@@ -78,14 +78,14 @@ extension BrowserTab: RSSSource {
7878
}
7979
// use javascript to detect RSS feed link
8080
// TODO: deal with multiple links
81-
waitForAsyncExecution(until: DispatchTime.now() + DispatchTimeInterval.milliseconds(200)) { finishHandler in
82-
self.webView.evaluateJavaScript(BrowserTab.extractRssLinkScript) { result, error in
81+
waitForAsyncExecution(until: DispatchTime.now() + DispatchTimeInterval.milliseconds(200)) { [weak self] finishHandler in
82+
self?.webView.evaluateJavaScript(BrowserTab.extractRssLinkScript) { result, error in
8383
if error == nil, let result = result as? [String] {
8484
// RSS feed link(s) detected
85-
self.rssUrls = result.compactMap { URL(string: $0 as String) }
85+
self?.rssUrls = result.compactMap { URL(string: $0 as String) }
8686
} else {
8787
// error or no rss url available
88-
self.rssUrls = []
88+
self?.rssUrls = []
8989
}
9090
finishHandler()
9191
}

0 commit comments

Comments
 (0)