[nodejs] Enable nodejs build for Travis

Changes:
- Add linter support
- Fix node-gyp issue with multiple python2
- Fix a typo of "make -j" and run as normal user
- Adjust steps and do better format
- Stop on failures on script step

Author: Halton Huo

.travis.yml

@@ -7,43 +7,60 @@ sudo: required
 dist: xenial
 
 before_install:
+  # Install nodejs via nvm
+  - wget -qO- https://raw.githubusercontent.com/creationix/nvm/v0.33.2/install.sh | bash
+  - source ~/.bashrc
+  - nvm install 6 && nvm use 6
+  - npm install -g node-gyp
+
+  # Remove duplicated python 2.x, otherwise node-gyp will complain and stop
+  - pyenv uninstall -f 2.7.13
+
+  # Run linter
+  - git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git
+  - export OLDPATH=$PATH && export PATH=$PATH:$(pwd)/depot_tools;
+  - cd wrappers/nodejs/tools && npm install && cd ..
+  - node ./tools/linter.js
+  - export PATH=$OLDPATH && unset OLDPATH && cd ../../
+
+  # Get logical CPU number
+  - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then
+      export CPU_NUM=`grep -c ^processor /proc/cpuinfo`;
+    elif [ "$TRAVIS_OS_NAME" == "osx" ]; then
+      export CPU_NUM=`sysctl -n hw.logicalcpu_max`;
+    fi
+
+  # Install linux required packages
   - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then
       sudo add-apt-repository --yes ppa:ubuntu-toolchain-r/test;
-      wget https://github.com/glfw/glfw/releases/download/3.1.1/glfw-3.1.1.zip;
-      sudo apt-get update;
-      sudo apt-get-repository ppa:ubuntu-toolchain-r/test;
       sudo apt-get update;
+      sudo apt-get install -qq build-essential xorg-dev libglu1-mesa-dev libglew-dev libglm-dev;
+      sudo apt-get install -qq libusb-1.0-0-dev;
+      sudo apt-get install -qq libgtk-3-dev;
+      sudo apt-get install -qq python python-dev;
       sudo apt-get install gcc-5 g++-5;
       sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-5 60 --slave /usr/bin/g++ g++ /usr/bin/g++-5;
     fi
 
 install:
-  - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then
-      sudo apt-get install -qq build-essential xorg-dev libglu1-mesa-dev libglew-dev libglm-dev;
-      sudo apt-get install -qq cmake;
-      sudo apt-get install -qq libusb-1.0-0-dev ;
-      sudo apt-get install -qq libgtk-3-dev ;
-      sudo apt-get install python python-dev ;
-      pyenv local 3.6.1;
-
-      cmake --version;
-
-      unzip glfw-3.1.1.zip;
-      cd glfw-3.1.1;
-      sudo cmake -G "Unix Makefiles" -DBUILD_SHARED_LIBS=ON;
-      sudo make;
-      sudo make install;
-      cd ..;
-    fi
+  # Install nodejs via nvm
+  - wget https://github.com/glfw/glfw/releases/download/3.1.1/glfw-3.1.1.zip
+  - unzip glfw-3.1.1.zip && cd glfw-3.1.1
+  - cmake -G "Unix Makefiles" -DBUILD_SHARED_LIBS=ON
+  - make -j $CPU_NUM
+  - sudo make install && cd ..
+
 script:
-  - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then
-      uname -a;
-      mkdir build;
-      cd build;
-      cmake .. -DBUILD_EXAMPLES:BOOL=true -DBUILD_PYTHON_BINDINGS:BOOL=true;
-      make -J;
-      sudo make install;
-      export LRS_LOG_LEVEL="DEBUG";
-      wget http://realsense-hw-public.s3.amazonaws.com/rs-tests/awgc4;
-      ./unit-tests/live-test from awgc4 -d yes;
-    fi
+  # Exit immediately if a command exits with a non-zero status
+  - set -e
+  # Build librealsense
+  - pyenv local 3.6.1
+  - mkdir build && cd build
+  - cmake .. -DBUILD_EXAMPLES:BOOL=true -DBUILD_PYTHON_BINDINGS:BOOL=true -DBUILD_NODEJS_BINDINGS:BOOL=true
+  - make -j $CPU_NUM
+  - sudo "PATH=$PATH" make install
+
+  # Run test
+  - export LRS_LOG_LEVEL="DEBUG"
+  - wget http://realsense-hw-public.s3.amazonaws.com/rs-tests/awgc4
+  - ./unit-tests/live-test from awgc4 -d yes

wrappers/nodejs/.eslintrc.json

@@ -0,0 +1,29 @@
+{
+  "extends": "google",
+  "parserOptions": {
+    "ecmaVersion": 6
+  },
+  "plugins": [
+    "header"
+  ],
+  "rules": {
+    "header/header": [2, "tools/header.js"],
+    "max-len": ["error",
+      // Following Google Javascript 100 char line limit
+      100,
+      // Use 2-space as tab width
+      2,
+      { "ignoreUrls": true }
+    ],
+    // Prefer to use single quotes
+    "quotes": ["error", "single"],
+    // Disable JSDoc
+    "require-jsdoc": ["error", {
+      "require": {
+        "FunctionDeclaration": false,
+        "MethodDefinition": false,
+        "ClassDeclaration": false
+      }
+    }]
+  }
+}

wrappers/nodejs/.gitignore

@@ -1,8 +1,12 @@
+# Ignore files
+build
 doc/*
-!doc/jsdoc-template
 node_modules/
-!package-lock.json
-!package.json
-build
 *.png
 *.csv
+
+# Uningore files
+!.eslintrc.json
+!doc/jsdoc-template
+!package-lock.json
+!package.json

wrappers/nodejs/.jshintrc

@@ -0,0 +1,4 @@
+{
+  "esversion": 6,
+  "node": true
+}

wrappers/nodejs/tools/header.js

@@ -0,0 +1,3 @@
+// Copyright (c) 2017 Intel Corporation. All rights reserved.
+// Use of this source code is governed by an Apache 2.0 license
+// that can be found in the LICENSE file.

wrappers/nodejs/tools/linter.js

@@ -0,0 +1,74 @@
+#!/usr/bin/env node
+
+// Copyright (c) 2017 Intel Corporation. All rights reserved.
+// Use of this source code is governed by an Apache 2.0 license
+// that can be found in the LICENSE file.
+
+'use strict';
+
+const os = require('os');
+const path = require('path');
+const recursive = require('recursive-readdir');
+const spawn = require('child_process').spawnSync;
+const which = require('which');
+
+let errors = [];
+
+function doCppLint(files) {
+  if (!files) return;
+
+  let cpplint = which.sync('cpplint.py');
+  if (!cpplint) {
+    console.log('You need install depot_tools, and add to PATH.' +
+                ' https://dev.chromium.org/developers/how-tos/install-depot-tools');
+    process.exit(1);
+  }
+
+  let cmdOptions = [cpplint];
+  cmdOptions = cmdOptions.concat(files);
+  // cpplint report result in stderr, $? is always 0 whatever there are errors or not.
+  // So we need check the last line as "Total errors found: 0"
+  let output = spawn('python', cmdOptions).stderr.toString().split(os.EOL);
+  if (output[output.length - 2] != 'Total errors found: 0') {
+    errors = errors.concat(output);
+  }
+}
+
+function doJsLint(files) {
+  if (!files) return;
+
+  let jsLinterDir = path.join(__dirname, 'node_modules', '.bin');
+
+  for (let linter of ['eslint', 'jshint']) {
+    let cmdOptions = [path.join(jsLinterDir, linter)];
+    cmdOptions = cmdOptions.concat(files);
+    let output = spawn('node', cmdOptions).stdout.toString();
+    if (output) {
+      let lines = output.split(os.EOL);
+      if (lines.length > 0) errors = errors.concat(lines);
+    }
+  }
+}
+
+recursive(path.dirname(__dirname),
+          // ignore files
+          ['node_modules', 'prettify'],
+          function(err, files) {
+  let cppFiles = [];
+  let jsFiles = [];
+  for (let f of files) {
+    if (path.extname(f) == '.js') {
+      jsFiles.push(f);
+    } else if (path.extname(f) == '.cpp') {
+      cppFiles.push(f);
+    }
+  }
+
+  doCppLint(cppFiles);
+  doJsLint(jsFiles);
+
+  if (errors.length > 1) {
+    for (let l of errors) console.log(l);
+    process.exit(1);
+  }
+});