Updating tests in line with OIDC URI fix

Author: superchilled

lib/vonage/client.rb

@@ -98,7 +98,7 @@ def network_number_verification
       @network_number_verification ||= T.let(NetworkNumberVerification.new(config), T.nilable(Vonage::NetworkNumberVerification))
     end
 
-    # @return [NetworkNumberVerification]
+    # @return [NetworkSIMSwap]
     #
     sig { returns(T.nilable(Vonage::NetworkSIMSwap)) }
     def network_sim_swap

lib/vonage/network_authentication/client_authentication.rb

@@ -24,7 +24,7 @@ def token(oidc_auth_code:, redirect_uri:, **params)
     end
 
     def generate_oidc_uri(purpose:, api_scope:, login_hint:, redirect_uri:, state: nil)
-      scope = "openid+dpv:#{purpose}##{api_scope}"
+      scope = "openid%20dpv:#{purpose}%23#{api_scope}"
       uri = "https://oidc.idp.vonage.com/oauth2/auth?" +
         "client_id=#{@config.application_id}" +
         "&response_type=code" +

lib/vonage/network_authentication/server_authentication.rb

@@ -22,7 +22,7 @@ def token(purpose:, api_scope:, login_hint:, **params)
     end
 
     def bc_authorize(purpose:, api_scope:, login_hint:)
-      scope = "openid+dpv:#{purpose}##{api_scope}"
+      scope = "openid dpv:#{purpose}##{api_scope}"
       request(
         "/oauth2/bc-authorize",
         params: {

lib/vonage/network_number_verification.rb

@@ -73,7 +73,7 @@ def verify(phone_number:, auth_data:, hashed: false)
     #
     # @param [required, String] :redirect_uri The URI that will receive the callback containing the OIDC auth code.
     #
-    # @param [optional, String] :state A string that you can use for tracking. 
+    # @param [required, String] :state A string that you can use for tracking. 
     #   This field is optional, but it is recommended to set a unique identifier for each access token you generate.
     #
     # @return [String]

test/vonage/network_authentication/client_authentication_test.rb

@@ -58,7 +58,7 @@ def test_generate_oidc_uri_method
       redirect_uri: example_redirect_uri
     )
 
-    assert_equal "https://oidc.idp.vonage.com/oauth2/auth?client_id=#{application_id}&response_type=code&scope=openid+dpv:#{example_purpose}##{example_api_scope}&login_hint=#{example_login_hint}&redirect_uri=#{example_redirect_uri}", uri
+    assert_equal "https://oidc.idp.vonage.com/oauth2/auth?client_id=#{application_id}&response_type=code&scope=openid%20dpv:#{example_purpose}%23#{example_api_scope}&login_hint=#{example_login_hint}&redirect_uri=#{example_redirect_uri}", uri
   end
 
   def test_generate_oidc_uri_method_with_optional_params
@@ -70,7 +70,7 @@ def test_generate_oidc_uri_method_with_optional_params
       state: '12345'
     )
 
-    assert_equal "https://oidc.idp.vonage.com/oauth2/auth?client_id=#{application_id}&response_type=code&scope=openid+dpv:#{example_purpose}##{example_api_scope}&login_hint=#{example_login_hint}&redirect_uri=#{example_redirect_uri}&state=12345", uri
+    assert_equal "https://oidc.idp.vonage.com/oauth2/auth?client_id=#{application_id}&response_type=code&scope=openid%20dpv:#{example_purpose}%23#{example_api_scope}&login_hint=#{example_login_hint}&redirect_uri=#{example_redirect_uri}&state=12345", uri
   end
 
   def test_generate_oidc_uri_method_without_purpose

test/vonage/network_authentication/server_authentication_test.rb

@@ -28,7 +28,7 @@ def example_login_hint
 
   def test_bc_authorize_method
     request_params = {
-      scope: "openid+dpv:#{example_purpose}##{example_api_scope}",
+      scope: "openid dpv:#{example_purpose}##{example_api_scope}",
       login_hint: example_login_hint
     }
 
@@ -72,7 +72,7 @@ def test_request_access_token_method_without_auth_req_id
 
   def test_token_method
     bc_authorize_request_params = {
-      scope: "openid+dpv:#{example_purpose}##{example_api_scope}",
+      scope: "openid dpv:#{example_purpose}##{example_api_scope}",
       login_hint: example_login_hint
     }
 

test/vonage/network_number_verification_test.rb

@@ -152,13 +152,13 @@ def test_check_method_with_invalid_redirect_uri
   end
 
   def test_generate_client_uri_method
-    expected_uri = "https://oidc.idp.vonage.com/oauth2/auth?client_id=#{application_id}&response_type=code&scope=openid+dpv:FraudPreventionAndDetection#number-verification-verify-read&login_hint=#{phone_number}&redirect_uri=#{example_redirect_uri}"
+    expected_uri = "https://oidc.idp.vonage.com/oauth2/auth?client_id=#{application_id}&response_type=code&scope=openid%20dpv:FraudPreventionAndDetection%23number-verification-verify-read&login_hint=#{phone_number}&redirect_uri=#{example_redirect_uri}"
 
     assert_equal expected_uri, network_number_verification.generate_oidc_uri(phone_number: phone_number, redirect_uri: example_redirect_uri)
   end
 
   def test_generate_client_uri_method_with_optional_params
-    expected_uri = "https://oidc.idp.vonage.com/oauth2/auth?client_id=#{application_id}&response_type=code&scope=openid+dpv:FraudPreventionAndDetection#number-verification-verify-read&login_hint=#{phone_number}&redirect_uri=#{example_redirect_uri}&state=12345"
+    expected_uri = "https://oidc.idp.vonage.com/oauth2/auth?client_id=#{application_id}&response_type=code&scope=openid%20dpv:FraudPreventionAndDetection%23number-verification-verify-read&login_hint=#{phone_number}&redirect_uri=#{example_redirect_uri}&state=12345"
 
     assert_equal expected_uri, network_number_verification.generate_oidc_uri(phone_number: phone_number, redirect_uri: example_redirect_uri, state: '12345')
   end

test/vonage/network_sim_swap_test.rb

@@ -16,7 +16,7 @@ def phone_number
 
   def test_check_method
     bc_authorize_request_params = {
-      scope: "openid+dpv:FraudPreventionAndDetection#check-sim-swap",
+      scope: "openid dpv:FraudPreventionAndDetection#check-sim-swap",
       login_hint: phone_number
     }
 
@@ -36,7 +36,7 @@ def test_check_method
 
   def test_check_method_with_optional_params
     bc_authorize_request_params = {
-      scope: "openid+dpv:FraudPreventionAndDetection#check-sim-swap",
+      scope: "openid dpv:FraudPreventionAndDetection#check-sim-swap",
       login_hint: phone_number
     }
 
@@ -71,7 +71,7 @@ def test_check_method_with_invalid_max_age
 
   def test_retrieve_date_method
     bc_authorize_request_params = {
-      scope: "openid+dpv:FraudPreventionAndDetection#retrieve-sim-swap-date",
+      scope: "openid dpv:FraudPreventionAndDetection#retrieve-sim-swap-date",
       login_hint: phone_number
     }