Adding from validations to SMS and WhatsApp channels

Vonage · Apr 23, 2024 · 6719e10 · 6719e10
1 parent fe52ed9
commit 6719e10
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/vonage/verify2/channels/sms.rb b/lib/vonage/verify2/channels/sms.rb
@@ -20,6 +20,7 @@ def to=(to)
     end
 
     def from=(from)
+      validate_from(from)
       @from = from
     end
 
@@ -49,5 +50,14 @@ def to_h
     private
 
     attr_writer :channel
+
+    def validate_from(from)
+      if from.match?(/\D/)
+        raise ArgumentError, "Invalid alpha-numeric 'from' value #{from}. Length must be between 3 and 11 characters." unless from.length.between?(3, 11)
+      else
+        raise ArgumentError, "Invalid numeric 'from' value #{from}. Length must be between 11 and 15 characters." unless from.length.between?(11, 15)
+        raise ArgumentError, "Invalid 'from' value #{from}. Expected to be in E.164 format" unless Phonelib.parse(from).valid?
+      end
+    end
   end
 end
diff --git a/lib/vonage/verify2/channels/whats_app.rb b/lib/vonage/verify2/channels/whats_app.rb
@@ -19,6 +19,7 @@ def to=(to)
     end
 
     def from=(from)
+      raise ArgumentError, "Invalid 'from' value #{from}. Length must be between 11 and 15 characters." unless from.length.between?(11, 15)
       raise ArgumentError, "Invalid 'from' value #{from}. Expected to be in E.164 format" unless Phonelib.parse(from.to_i).valid?
       @from = from
     end