Updating network number verification tests

Author: superchilled

Diff for: lib/vonage/network_number_verification.rb

@@ -53,5 +53,19 @@ def verify(phone_number:, auth_data:, hashed: false)
         }
       )
     end
+
+    sig { params(phone_number: String, redirect_uri: String, state: T.nilable(String)).returns(String) }
+    def generate_oidc_uri(phone_number:, redirect_uri:, state: nil)
+      params = {
+        purpose: 'FraudPreventionAndDetection',
+        api_scope: 'number-verification-verify-read',
+        login_hint: phone_number,
+        redirect_uri: redirect_uri
+      }
+
+      params[:state] = state if state
+
+      Vonage::NetworkAuthentication::ClientAuthentication.new(@config).generate_oidc_uri(**params)
+    end
   end
 end

Diff for: test/vonage/network_authentication/client_authentication_test.rb

@@ -2,7 +2,7 @@
 require_relative '../test'
 
 class Vonage::NetworkAuthentication::ClientAuthenticationTest < Vonage::Test
-  def client
+  def client_authentication
     Vonage::NetworkAuthentication::ClientAuthentication.new(config)
   end
 
@@ -39,19 +39,19 @@ def test_token_method
 
     stub_request(:post, token_uri).with(request(body: request_params, headers: headers)).to_return(network_authentication_token_response)
 
-    assert_equal sample_webhook_token, client.token(oidc_auth_code: example_oidc_auth_code, redirect_uri: example_redirect_uri)
+    assert_equal sample_webhook_token, client_authentication.token(oidc_auth_code: example_oidc_auth_code, redirect_uri: example_redirect_uri)
   end
 
   def test_token_method_without_oidc_auth_code
-    assert_raises(ArgumentError) { client.token(redirect_uri: example_redirect_uri) }
+    assert_raises(ArgumentError) { client_authentication.token(redirect_uri: example_redirect_uri) }
   end
 
   def test_token_method_without_redirect_uri
-    assert_raises(ArgumentError) { client.token(oidc_auth_code: example_oidc_auth_code) }
+    assert_raises(ArgumentError) { client_authentication.token(oidc_auth_code: example_oidc_auth_code) }
   end
 
   def test_generate_oidc_uri_method
-    uri = client.generate_oidc_uri(
+    uri = client_authentication.generate_oidc_uri(
       purpose: example_purpose,
       api_scope: example_api_scope,
       login_hint: example_login_hint,
@@ -62,7 +62,7 @@ def test_generate_oidc_uri_method
   end
 
   def test_generate_oidc_uri_method_with_optional_params
-    uri = client.generate_oidc_uri(
+    uri = client_authentication.generate_oidc_uri(
       purpose: example_purpose,
       api_scope: example_api_scope,
       login_hint: example_login_hint,
@@ -74,18 +74,18 @@ def test_generate_oidc_uri_method_with_optional_params
   end
 
   def test_generate_oidc_uri_method_without_purpose
-    assert_raises(ArgumentError) { client.generate_oidc_uri(api_scope: example_api_scope, login_hint: example_login_hint, redirect_uri: example_redirect_uri) }
+    assert_raises(ArgumentError) { client_authentication.generate_oidc_uri(api_scope: example_api_scope, login_hint: example_login_hint, redirect_uri: example_redirect_uri) }
   end
 
   def test_generate_oidc_uri_method_without_api_scope
-    assert_raises(ArgumentError) { client.generate_oidc_uri(purpose: example_purpose, login_hint: example_login_hint, redirect_uri: example_redirect_uri) }
+    assert_raises(ArgumentError) { client_authentication.generate_oidc_uri(purpose: example_purpose, login_hint: example_login_hint, redirect_uri: example_redirect_uri) }
   end
 
   def test_generate_oidc_uri_method_without_login_hint
-    assert_raises(ArgumentError) { client.generate_oidc_uri(purpose: example_purpose, api_scope: example_api_scope, redirect_uri: example_redirect_uri) }
+    assert_raises(ArgumentError) { client_authentication.generate_oidc_uri(purpose: example_purpose, api_scope: example_api_scope, redirect_uri: example_redirect_uri) }
   end
 
   def test_generate_oidc_uri_method_without_redirect_uri
-    assert_raises(ArgumentError) { client.generate_oidc_uri(purpose: example_purpose, api_scope: example_api_scope, login_hint: example_login_hint) }
+    assert_raises(ArgumentError) { client_authentication.generate_oidc_uri(purpose: example_purpose, api_scope: example_api_scope, login_hint: example_login_hint) }
   end
 end

Diff for: test/vonage/network_authentication/server_authentication_test.rb

@@ -2,7 +2,7 @@
 require_relative '../test'
 
 class Vonage::NetworkAuthentication::ServerAuthenticationTest < Vonage::Test
-  def server
+  def server_authentication
     Vonage::NetworkAuthentication::ServerAuthentication.new(config)
   end
 
@@ -34,22 +34,22 @@ def test_bc_authorize_method
 
     stub_request(:post, bc_authorize_uri).with(request(body: request_params, headers: headers)).to_return(network_authentication_oicd_response)
 
-    response = server.bc_authorize(purpose: example_purpose, api_scope: example_api_scope, login_hint: example_login_hint)
+    response = server_authentication.bc_authorize(purpose: example_purpose, api_scope: example_api_scope, login_hint: example_login_hint)
 
     assert_kind_of Vonage::Response, response
     assert_equal network_authentication_auth_request_id, response.auth_req_id
   end
 
   def test_bc_authorize_method_without_purpose
-    assert_raises(ArgumentError) { server.bc_authorize(api_scope: example_api_scope, login_hint: example_login_hint) }
+    assert_raises(ArgumentError) { server_authentication.bc_authorize(api_scope: example_api_scope, login_hint: example_login_hint) }
   end
 
   def test_bc_authorize_method_without_api_scope
-    assert_raises(ArgumentError) { server.bc_authorize(purpose: example_purpose, login_hint: example_login_hint) }
+    assert_raises(ArgumentError) { server_authentication.bc_authorize(purpose: example_purpose, login_hint: example_login_hint) }
   end
 
   def test_bc_authorize_method_without_login_hint
-    assert_raises(ArgumentError) { server.bc_authorize(purpose: example_purpose, api_scope: example_api_scope) }
+    assert_raises(ArgumentError) { server_authentication.bc_authorize(purpose: example_purpose, api_scope: example_api_scope) }
   end
 
   def test_request_access_token_method
@@ -60,14 +60,14 @@ def test_request_access_token_method
 
     stub_request(:post, token_uri).with(request(body: request_params, headers: headers)).to_return(network_authentication_token_response)
 
-    response = server.request_access_token(auth_req_id: network_authentication_auth_request_id)
+    response = server_authentication.request_access_token(auth_req_id: network_authentication_auth_request_id)
 
     assert_kind_of Vonage::Response, response
     assert_equal sample_webhook_token, response.access_token
   end
 
   def test_request_access_token_method_without_auth_req_id
-    assert_raises(ArgumentError) { server.request_access_token }
+    assert_raises(ArgumentError) { server_authentication.request_access_token }
   end
 
   def test_token_method
@@ -84,18 +84,18 @@ def test_token_method
     stub_request(:post, bc_authorize_uri).with(request(body: bc_authorize_request_params, headers: headers)).to_return(network_authentication_oicd_response)
     stub_request(:post, token_uri).with(request(body: request_access_token_request_params, headers: headers)).to_return(network_authentication_token_response)
 
-    assert_equal sample_webhook_token, server.token(purpose: example_purpose, api_scope: example_api_scope, login_hint: example_login_hint)
+    assert_equal sample_webhook_token, server_authentication.token(purpose: example_purpose, api_scope: example_api_scope, login_hint: example_login_hint)
   end
 
   def test_token_method_without_purpose
-    assert_raises(ArgumentError) { server.token(api_scope: example_api_scope, login_hint: example_login_hint) }
+    assert_raises(ArgumentError) { server_authentication.token(api_scope: example_api_scope, login_hint: example_login_hint) }
   end
 
   def test_token_method_without_api_scope
-    assert_raises(ArgumentError) { server.token(purpose: example_purpose, login_hint: example_login_hint) }
+    assert_raises(ArgumentError) { server_authentication.token(purpose: example_purpose, login_hint: example_login_hint) }
   end
 
   def test_token_method_without_login_hint
-    assert_raises(ArgumentError) { server.token(purpose: example_purpose, api_scope: example_api_scope) }
+    assert_raises(ArgumentError) { server_authentication.token(purpose: example_purpose, api_scope: example_api_scope) }
   end
 end

Diff for: test/vonage/network_number_verification_test.rb

@@ -150,4 +150,24 @@ def test_check_method_with_invalid_redirect_uri
 
     assert_raises(ArgumentError) { network_number_verification.verify(phone_number: phone_number, auth_data: auth_data) }
   end
+
+  def test_generate_client_uri_method
+    expected_uri = "https://oidc.idp.vonage.com/oauth2/auth?client_id=#{application_id}&response_type=code&scope=openid+dpv:FraudPreventionAndDetection#number-verification-verify-read&login_hint=#{phone_number}&redirect_uri=#{example_redirect_uri}"
+
+    assert_equal expected_uri, network_number_verification.generate_oidc_uri(phone_number: phone_number, redirect_uri: example_redirect_uri)
+  end
+
+  def test_generate_client_uri_method_with_optional_params
+    expected_uri = "https://oidc.idp.vonage.com/oauth2/auth?client_id=#{application_id}&response_type=code&scope=openid+dpv:FraudPreventionAndDetection#number-verification-verify-read&login_hint=#{phone_number}&redirect_uri=#{example_redirect_uri}&state=12345"
+
+    assert_equal expected_uri, network_number_verification.generate_oidc_uri(phone_number: phone_number, redirect_uri: example_redirect_uri, state: '12345')
+  end
+
+  def test_generate_client_uri_method_without_phone_number
+    assert_raises(ArgumentError) { network_number_verification.generate_oidc_uri(redirect_uri: example_redirect_uri) }
+  end
+
+  def test_generate_client_uri_method_without_redirect_uri
+    assert_raises(ArgumentError) { network_number_verification.generate_oidc_uri(phone_number: phone_number) }
+  end
 end