Skip to content

Commit 98da06d

Browse files
committed
added Tests for ExplicitImports, use latest julia version in ci.yml
1 parent 5eb1c17 commit 98da06d

File tree

5 files changed

+16
-8
lines changed

5 files changed

+16
-8
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
fail-fast: false
1717
matrix:
1818
version:
19-
- '1.9' # Replace this with the minimum Julia version that your package supports. E.g. if your package requires Julia 1.5 or higher, change this to '1.5'.
19+
- 'lts' # Replace this with the minimum Julia version that your package supports. E.g. if your package requires Julia 1.5 or higher, change this to '1.5'.
2020
- '1' # Leave this line unchanged. '1' will automatically expand to the latest stable 1.x release of Julia.
2121
# - 'nightly'
2222
os:

ext/ExtendableFEMBaseUnicodePlotsExt.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module ExtendableFEMBaseUnicodePlotsExt
33
using ExtendableGrids: ExtendableGrid, simplexgrid, ON_CELLS, ON_FACES, ON_EDGES, CellNodes, CellGeometries, BFaceNodes, BFaceRegions, Coordinates
44
using ExtendableFEMBase: FEVector, FEVectorBlock, FESpace, lazy_interpolate!, num_cells, local_celledgenodes, get_ncomponents, H1P1, IdentityComponent, standard_kernel
55
using UnicodePlots: UnicodePlots, BrailleCanvas, Plot, heatmap, lineplot,
6-
lineplot!, lines!
6+
lineplot!, lines!
77

88
import ExtendableFEMBase: unicode_gridplot, unicode_scalarplot
99

@@ -140,9 +140,9 @@ function unicode_scalarplot(
140140
title = title * (length(components) == 1 ? "" : "[$(components[c])]"),
141141
colormap = colormap,
142142
) for c 1:length(components)
143-
]
144-
return length(plts) == 1 ? plts[1] : plts
145-
## the following command looks nicer, but requires the Term-based extension of UnicodePlots
143+
]
144+
return length(plts) == 1 ? plts[1] : plts
145+
## the following command looks nicer, but requires the Term-based extension of UnicodePlots
146146
## return UnicodePlots.gridplot(map(i -> plts[i], 1:length(components)); layout = (nrows, nothing))
147147
end
148148
end

src/ExtendableFEMBase.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ using ExtendableGrids: ExtendableGrids, AT_NODES, AbstractElementGeometry,
1313
AbstractGridFloatArray2D, AbstractGridIntegerArray2D,
1414
Adjacency, AssemblyType, BEdgeEdges, BEdgeGeometries,
1515
BEdgeRegions, BEdgeVolumes, BFaceEdges, BFaceFaces,
16-
BFaceGeometries, BFaceNodes, BFaceParents, BFaceRegions,
16+
BFaceGeometries, BFaceParents, BFaceRegions,
1717
BFaceVolumes, CellEdgeSigns, CellEdges,
1818
CellFaceOrientations, CellFaceSigns, CellFaces,
1919
CellFinder, CellGeometries, CellNodes, CellParents,
@@ -40,7 +40,7 @@ using ExtendableGrids: ExtendableGrids, AT_NODES, AbstractElementGeometry,
4040
local_celledgenodes, local_cellfacenodes, mapderiv!,
4141
max_num_targets_per_source, num_cells, num_edges,
4242
num_faces, num_nodes, num_sources, num_targets,
43-
reference_domain, simplexgrid, subgrid, unique,
43+
reference_domain, subgrid, unique,
4444
update_trafo!
4545
using ExtendableSparse: ExtendableSparse, ExtendableSparseMatrix, flush!,
4646
AbstractExtendableSparseMatrixCSC, ExtendableSparseMatrixCSC, MTExtendableSparseMatrixCSC,
@@ -51,7 +51,7 @@ using LinearAlgebra: LinearAlgebra, convert, det, diagm, dot, eigen, ldiv!, lu,
5151
using Polynomials: Polynomials, Polynomial, coeffs
5252
using Printf: Printf, @printf
5353
using SparseArrays: SparseArrays, AbstractSparseArray, AbstractSparseMatrix,
54-
SparseMatrixCSC, nzrange, rowvals, sparse
54+
SparseMatrixCSC, nzrange, rowvals
5555
using SpecialPolynomials: SpecialPolynomials, ShiftedLegendre, basis
5656

5757
include("functionoperators.jl")

test/Project.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ ExtendableFEMBase = "12fb9182-3d4c-4424-8fd1-727a0899810c"
33
ExtendableSparse = "95c220a8-a1cf-11e9-0c77-dbfce5f500b3"
44
ExtendableGrids = "cfc395e8-590f-11e8-1f13-43a2532b2fa8"
55
ExampleJuggler = "3bbe58f8-ed81-4c4e-a134-03e85fcf4a1a"
6+
ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
67
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
78
GridVisualize = "5eed8a63-0fb0-45eb-886d-8d5a387d12b8"
89
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

test/runtests.jl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
using Test
22
using ExtendableGrids
33
using ExtendableFEMBase
4+
using ExplicitImports
45
using ExampleJuggler
56
using SparseArrays
67
using Aqua
@@ -14,12 +15,18 @@ using Aqua
1415
Aqua.test_ambiguities(ExtendableFEMBase)
1516
end
1617

18+
@testset "ExplicitImports" begin
19+
@test ExplicitImports.check_no_implicit_imports(ExtendableFEMBase) === nothing
20+
@test ExplicitImports.check_no_stale_explicit_imports(ExtendableFEMBase) === nothing
21+
end
22+
1723
if isdefined(Docs, :undocumented_names) # >=1.11
1824
@testset "UndocumentedNames" begin
1925
@test isempty(Docs.undocumented_names(ExtendableFEMBase))
2026
end
2127
end
2228

29+
2330
include("test_quadrature.jl")
2431
include("test_interpolators.jl")
2532
include("test_operators.jl")

0 commit comments

Comments
 (0)