Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls the install and open icon in the address bar #23

Closed
hanguokai opened this issue Aug 7, 2021 · 4 comments
Closed

Controls the install and open icon in the address bar #23

hanguokai opened this issue Aug 7, 2021 · 4 comments

Comments

@hanguokai
Copy link

Screen Shot 2021-08-07 at 5 13 25 PM

Screen Shot 2021-08-07 at 5 13 40 PM

As shown in the images above, the browser address bar has install icon and open icon for installing and launching the app. But not all web pages in the origin should be used for it. For example, help pages of the app should be opened as general web pages in the browser, rather than load them into the app.

So the website should controls whether the install and open icon is displayed for a page. For example control it by manifest or by javascript.

@meduzen
Copy link

meduzen commented Aug 7, 2021

I think we shouldn’t decide for the users: they should be free to open whatever page how they want.

Also, we already have the Web Manifest scope that can be used to limit the URL scope of an installable app.

In the use case you mention, if the help section is outside the Web Manifest scope, then the browser will threat it as an external website, if I’m correct.

@hanguokai
Copy link
Author

I considered the scope. But it is not sufficient for all cases. For example, the landing page of the app is /. And there is an install button on the landing page. To make the install button work, the scope of the manifest and service worker should also be set /.

@hanguokai
Copy link
Author

Generally, users don't know which part of pages in the origin can be loaded into the app. Developers know it.

@hanguokai
Copy link
Author

Move this issue to w3c/manifest#996 . I listed more behaviors of the install icon and launch icon w3c/manifest#996 (comment) . But they are not clearly defined in the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants