Skip to content

Commit

Permalink
Update manifest examples to show origin scheme (#26)
Browse files Browse the repository at this point in the history
Currently the "https://" scheme is required by the `origin` fields in
`url_handlers`. This is consistent with Chromium's manifest parser
implementation. This change updates the manifest examples in this
explainer to reflect that. If there is feedback, we could consider
also allowing a short form of origin strings where the "https://" scheme
is implied.
  • Loading branch information
LuHuangMSFT authored Jun 9, 2021
1 parent f8af6a7 commit 1c553c3
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions explainer.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,13 @@ Example web app manifest at `https://contoso.com/manifest.json` :
"capture_links": "existing_client_event",
"url_handlers" : [
{
"origin": "contoso.com"
"origin": "https://contoso.com"
},
{
"origin": "conto.so"
"origin": "https://conto.so"
},
{
"origin": "*.contoso.com"
"origin": "https://*.contoso.com"
}
]
}
Expand All @@ -119,13 +119,13 @@ Example web app manifest at `https://partnerapp.com/manifest.json`
"capture_links": "existing_client_event",
"url_handlers": [
{
"origin": "contoso.com"
"origin": "https://contoso.com"
},
{
"origin": "conto.so"
"origin": "https://conto.so"
},
{
"origin": "*.contoso.com"
"origin": "https://*.contoso.com"
}
]
}
Expand Down

0 comments on commit 1c553c3

Please sign in to comment.