Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider using URLPattern for hostname and path matching #21

Open
wanderview opened this issue Oct 30, 2020 · 2 comments
Open

consider using URLPattern for hostname and path matching #21

wanderview opened this issue Oct 30, 2020 · 2 comments
Assignees

Comments

@wanderview
Copy link

Looking at the explainer it appears to use custom pattern matching for the url_handlers origins and web_apps paths. Rather than create a new one-off pattern matcher, it would be nice to re-use the primitive we are building in https://github.com/WICG/urlpattern. Its initially being integrated into service workers, but we plan to bring it to manifest scope and other web APIs as well.

For more info see:

The design doc has a lot more detail on the pattern API.

I'm actively implementing URLPattern now and plan to have it in testable shape behind a flag in Q4.

I'd be happy to work with you to figure out how best to integrate it into pwa-url-handler. Also, if it doesn't meet your use cases for some reasons it would also be great to have that feedback. Thanks.

@LuHuangMSFT LuHuangMSFT self-assigned this Nov 4, 2020
@LuHuangMSFT
Copy link
Collaborator

Thanks. It's good to see so much progress in the URLPattern work. I'll review the current docs and follow up.

@LuHuangMSFT
Copy link
Collaborator

As promised here
I'll prepare a PR of this explainer that uses URLPattern asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants