Use spread operator instead of node.extend to reduce bundle size

Author: kadamwhite

lib/constructors/wp-request.js

@@ -2,7 +2,6 @@
 
 const qs = require( 'qs' );
 const _unique = require( 'lodash.uniq' );
-const extend = require( 'node.extend' );
 
 const alphaNumericSort = require( '../util/alphanumeric-sort' );
 const keyValToObj = require( '../util/key-val-to-obj' );
@@ -227,11 +226,16 @@ const validatePathLevel = ( levelDefinitions, levelContents ) => {
  */
 WPRequest.prototype._renderQuery = function() {
 	// Build the full query parameters object
-	const queryParams = extend( {}, populated( this._params ) );
+	const queryParams = {
+		...populated( this._params ),
+	};
 
 	// Prepare any taxonomies and merge with other filter values
 	const taxonomies = prepareTaxonomies( this._taxonomyFilters );
-	queryParams.filter = extend( {}, populated( this._filters ), taxonomies );
+	queryParams.filter = {
+		...populated( this._filters ),
+		...taxonomies,
+	};
 
 	// Parse query parameters object into a query string, sorting the object
 	// properties by alphabetical order (consistent property ordering can make

lib/endpoint-factories.js

@@ -6,7 +6,6 @@
  */
 'use strict';
 
-const extend = require( 'node.extend' );
 const createResourceHandlerSpec = require( './resource-handler-spec' ).create;
 const createEndpointRequest = require( './endpoint-request' ).create;
 const objectReduce = require( './util/object-reduce' );
@@ -39,7 +38,10 @@ function generateEndpointFactories( routesByNamespace ) {
 			// "handler" object is now fully prepared; create the factory method that
 			// will instantiate and return a handler instance
 			handlers[ resource ] = function( options ) {
-				return new EndpointRequest( extend( {}, this._options, options ) );
+				return new EndpointRequest( {
+					...this._options,
+					...options,
+				} );
 			};
 
 			// Expose the constructor as a property on the factory function, so that

lib/http-transport.js

@@ -9,7 +9,6 @@ const url = require( 'url' );
 
 const WPRequest = require( './constructors/wp-request' );
 const checkMethodSupport = require( './util/check-method-support' );
-const extend = require( 'node.extend' );
 const objectReduce = require( './util/object-reduce' );
 const isEmptyObject = require( './util/is-empty-object' );
 
@@ -177,18 +176,20 @@ function createPaginationObject( result, options, httpTransport ) {
 
 	// Create a WPRequest instance pre-bound to the "next" page, if available
 	if ( links.next ) {
-		_paging.next = new WPRequest( extend( {}, options, {
+		_paging.next = new WPRequest( {
+			...options,
 			transport: httpTransport,
 			endpoint: mergeUrl( endpoint, links.next ),
-		} ) );
+		} );
 	}
 
 	// Create a WPRequest instance pre-bound to the "prev" page, if available
 	if ( links.prev ) {
-		_paging.prev = new WPRequest( extend( {}, options, {
+		_paging.prev = new WPRequest( {
+			...options,
 			transport: httpTransport,
 			endpoint: mergeUrl( endpoint, links.prev ),
-		} ) );
+		} );
 	}
 
 	return _paging;

lib/mixins/filters.js

@@ -4,7 +4,6 @@
 'use strict';
 
 const _unique = require( 'lodash.uniq' );
-const extend = require( 'node.extend' );
 
 const alphaNumericSort = require( '../util/alphanumeric-sort' );
 const keyValToObj = require( '../util/key-val-to-obj' );
@@ -57,7 +56,10 @@ filterMixins.filter = function( props, value ) {
 		props = keyValToObj( props, value );
 	}
 
-	this._filters = extend( this._filters, props );
+	this._filters = {
+		...this._filters,
+		...props,
+	};
 
 	return this;
 };

lib/wp-register-route.js

@@ -1,7 +1,5 @@
 'use strict';
 
-const extend = require( 'node.extend' );
-
 const buildRouteTree = require( './route-tree' ).build;
 const generateEndpointFactories = require( './endpoint-factories' ).generate;
 const paramSetter = require( './util/parameter-setter' );
@@ -90,10 +88,11 @@ function registerRoute( namespace, restBase, options = {} ) {
 		} );
 	}
 
-	function endpointFactory( options ) {
-		options = options || {};
-		options = extend( options, this && this._options );
-		return new EndpointRequest( options );
+	function endpointFactory( options = {} ) {
+		return new EndpointRequest( {
+			...options,
+			...( this ? this._options : {} ),
+		} );
 	}
 	endpointFactory.Ctor = EndpointRequest;
 

package.json

@@ -60,7 +60,6 @@
   "dependencies": {
     "li": "^1.0.1",
     "lodash.uniq": "^4.3.0",
-    "node.extend": "^1.1.5",
     "parse-link-header": "^0.4.1",
     "qs": "^6.2.0",
     "route-parser": "0.0.4",

wpapi.js

@@ -14,7 +14,6 @@
  */
 'use strict';
 
-const extend = require( 'node.extend' );
 const objectReduce = require( './lib/util/object-reduce' );
 
 // This JSON file provides enough data to create handler methods for all valid
@@ -232,10 +231,10 @@ WPAPI.site = function( endpoint, routes ) {
  * @returns {WPRequest} A WPRequest object bound to the provided URL
  */
 WPAPI.prototype.url = function( url ) {
-	const options = extend( {}, this._options, {
+	return new WPRequest( {
+		...this._options,
 		endpoint: url,
 	} );
-	return new WPRequest( options );
 };
 
 /**
@@ -248,7 +247,9 @@ WPAPI.prototype.url = function( url ) {
  */
 WPAPI.prototype.root = function( relativePath ) {
 	relativePath = relativePath || '';
-	const options = extend( {}, this._options );
+	const options = {
+		...this._options,
+	};
 	// Request should be
 	const request = new WPRequest( options );