Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We are serving languages incorrectly somehow? #207

Open
markwhiting opened this issue Oct 9, 2024 · 0 comments
Open

We are serving languages incorrectly somehow? #207

markwhiting opened this issue Oct 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@markwhiting
Copy link
Member

It looks like whatever we are doing to set language is a bit incorrect, which could lead to problems down the road.

Bug : Site returns content in Russian when opened in Latvia, despite browser language settings set to prefer (in that order): Latvian [lv], English (UK) [en-gb], English [en], Russian [ru]. The site should have been served in English. Considering the country's history and its ethnic divides, this results in a mildly offensive experience for a first-time visitor of this site. The HTTP request headers are:
GET / HTTP/2 Host: commonsense.seas.upenn.edu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:130.0) Gecko/20100101 Firefox/130.0 Accept:
text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/png,image/svg+xml,/;q=0.8 Accept-Language: lv,en-GB;q=0.8,en;q=0.5,ru;q=0.3 Accept-Encoding: gzip, deflate, br, zstd DNT: 1 Connection: keep-alive Upgrade-Insecure-Requests: 1 Sec-Fetch-Dest: document Sec-Fetch-Mode: navigate Sec-Fetch-Site: none Sec-Fetch-User: ?1 Priority: u=0, i Pragma: no-cache Cache-Control: no-cache TE: trailers Note how Accept-Language is set to lv,en-GB;q=0.8,en;q=0.5,ru;q=0.3 by the browser but isn't respected by your website.

@markwhiting markwhiting added the bug Something isn't working label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant