Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queries should be able to be added onto an encrypted URL #23

Closed
markwhiting opened this issue Sep 16, 2021 · 0 comments · Fixed by #43
Closed

Queries should be able to be added onto an encrypted URL #23

markwhiting opened this issue Sep 16, 2021 · 0 comments · Fixed by #43
Labels
bug Something isn't working

Comments

@markwhiting
Copy link
Member

If a query is added manually after an encrypted url it should still work fine. However, if the encrypted url already has queries, and the added queries mention the same variable, Surveyor should use the encrypted version.

So, a url like:
/e/asdlfjasdf/?WorkerId=Mark
Would work and pass WorkerId on to Surveyor.

However, if a url like:
/s/?URL=google.com& WorkerId =Mark was encrypted to /e/123abc, then /e/123abc/?WorkerId=Duncan&Day=Tuesday then Surveyor would get {WorkerId: "Mark", Day: "Tuesday"} and we would just ignore the repeated WorkerId value.

@markwhiting markwhiting added the bug Something isn't working label Sep 16, 2021
@sumants-dev sumants-dev linked a pull request Nov 23, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant