OptimizeInstructions: Optimize unsigned(x) < 0 => i32(0) even with side effects (#7428)

Fixes #7418

Author: xuruiyang2002

src/passes/OptimizeInstructions.cpp

@@ -562,11 +562,11 @@ struct OptimizeInstructions
           return replaceCurrent(getDroppedChildrenAndAppend(curr, c));
         }
         // unsigned(x) < 0   =>   i32(0)
-        if (matches(curr, binary(LtU, pure(&x), ival(&c))) &&
+        if (matches(curr, binary(LtU, any(&x), ival(&c))) &&
             c->value.isZero()) {
           c->value = Literal::makeZero(Type::i32);
           c->type = Type::i32;
-          return replaceCurrent(c);
+          return replaceCurrent(getDroppedChildrenAndAppend(curr, c));
         }
       }
     }

test/lit/passes/optimize-instructions-mvp.wast

@@ -11476,9 +11476,29 @@
   ;; CHECK-NEXT:   (i32.const 0)
   ;; CHECK-NEXT:  )
   ;; CHECK-NEXT:  (drop
+  ;; CHECK-NEXT:   (block (result i32)
+  ;; CHECK-NEXT:    (drop
+  ;; CHECK-NEXT:     (i32.load
+  ;; CHECK-NEXT:      (i32.const 0)
+  ;; CHECK-NEXT:     )
+  ;; CHECK-NEXT:    )
+  ;; CHECK-NEXT:    (i32.const 0)
+  ;; CHECK-NEXT:   )
+  ;; CHECK-NEXT:  )
+  ;; CHECK-NEXT:  (drop
   ;; CHECK-NEXT:   (i32.const 0)
   ;; CHECK-NEXT:  )
   ;; CHECK-NEXT:  (drop
+  ;; CHECK-NEXT:   (block (result i32)
+  ;; CHECK-NEXT:    (drop
+  ;; CHECK-NEXT:     (i64.load
+  ;; CHECK-NEXT:      (i32.const 0)
+  ;; CHECK-NEXT:     )
+  ;; CHECK-NEXT:    )
+  ;; CHECK-NEXT:    (i32.const 0)
+  ;; CHECK-NEXT:   )
+  ;; CHECK-NEXT:  )
+  ;; CHECK-NEXT:  (drop
   ;; CHECK-NEXT:   (i32.ne
   ;; CHECK-NEXT:    (local.get $x)
   ;; CHECK-NEXT:    (i32.const 0)
@@ -11701,10 +11721,22 @@
       (local.get $x)
       (i32.const 0)
     ))
+    (drop (i32.lt_u
+      (i32.load
+       (i32.const 0)
+      )
+      (i32.const 0)
+    ))
     (drop (i64.lt_u
       (local.get $y)
       (i64.const 0)
     ))
+    (drop (i64.lt_u
+      (i64.load
+       (i32.const 0)
+      )
+      (i64.const 0)
+    ))
 
     ;; (unsigned)x > 0  =>  x != 0
     (drop (i32.gt_u

test/wasm2js/bulk-memory.2asm.js.opt

@@ -275,9 +275,6 @@ var retasmFunc = asmFunc({
 export var init = retasmFunc.init;
 export var load8_u = retasmFunc.load8_u;
 
-  var bufferView;
-function wasm2js_trap() { throw new Error('abort'); }
-
 function asmFunc(imports) {
  var buffer = new ArrayBuffer(65536);
  var HEAP8 = new Int8Array(buffer);
@@ -303,12 +300,9 @@ function asmFunc(imports) {
  }
 
  function $1() {
-  if (__wasm_memory_size() << 16 >>> 0 < 0) {
-   wasm2js_trap()
-  }
+  __wasm_memory_size();
  }
 
- bufferView = HEAPU8;
  function __wasm_memory_size() {
   return buffer.byteLength / 65536 | 0;
  }
@@ -330,7 +324,6 @@ function asmFunc(imports) {
    HEAPF32 = new Float32Array(newBuffer);
    HEAPF64 = new Float64Array(newBuffer);
    buffer = newBuffer;
-   bufferView = HEAPU8;
   }
   return oldPages;
  }