fixing linter issues

Author: GitMensch

.vscode/tasks.json

@@ -5,24 +5,29 @@
 // ${fileDirname}: the current opened file's dirname
 // ${fileExtname}: the current opened file's extension
 // ${cwd}: the current working directory of the spawned process
-
-// A task runner that calls a custom npm script that compiles the extension.
 {
 	"version": "2.0.0",
-
-	// Run in a shell so "npm" command is properly resolved to "npm.cmd" on Windows systems.
-	"type": "shell",
-
-	// we want to run npm
-	"command": "npm",
-
-	// we run the custom script "compile" as defined in package.json
-	"args": ["run", "compile", "--loglevel", "silent"],
-
-	// The tsc compiler is started in background mode
-	"isBackground": true,
-
-	// use the standard tsc in watch mode problem matcher to find compile problems in the output.
-	"problemMatcher": "$tsc-watch",
-	"tasks": []
+	"tasks": [
+		{
+			// A task runner that calls a custom npm script that compiles the extension.
+			"label": "compile",
+			// Run in a shell so "npm" command is properly resolved to "npm.cmd" on Windows systems.
+			"type": "shell",
+			// we want to run npm
+			"command": "npm",
+			// we run the custom script "compile" as defined in package.json
+			"args": [
+				"run",
+				"compile",
+				"--loglevel",
+				"silent"
+			],
+			// The tsc compiler is started in background mode
+			"isBackground": true,
+			// use the standard tsc in watch mode problem matcher to find compile problems in the output.
+			"problemMatcher": "$tsc-watch",
+			// that's our build
+			"group": "build"
+		}
+	]
 }

src/backend/mi2/mi2.ts

@@ -145,9 +145,9 @@ export class MI2 extends EventEmitter implements IBackend {
 				if (args.bootstrap) sshCMD = args.bootstrap + " && " + sshCMD;
 				this.sshConn.exec(sshCMD, execArgs, (err, stream) => {
 					if (err) {
-						this.log("stderr", "Could not run " + this.application + "(" + sshCMD +") over ssh!");
+						this.log("stderr", "Could not run " + this.application + "(" + sshCMD + ") over ssh!");
 						if (err === undefined) {
-							err = "<reason unknown>"
+							err = "<reason unknown>";
 						}
 						this.log("stderr", err.toString());
 						this.emit("quit");
@@ -177,7 +177,7 @@ export class MI2 extends EventEmitter implements IBackend {
 			}).on("error", (err) => {
 				this.log("stderr", "Error running " + this.application + " over ssh!");
 				if (err === undefined) {
-					err = "<reason unknown>"
+					err = "<reason unknown>";
 				}
 				this.log("stderr", err.toString());
 				this.emit("quit");
@@ -188,7 +188,7 @@ export class MI2 extends EventEmitter implements IBackend {
 
 	protected initCommands(target: string, cwd: string, attach: boolean = false) {
 		// We need to account for the possibility of the path type used by the debugger being different
-		// than the path type where the extension is running (e.g., SSH from Linux to Windows machine).
+		// from the path type where the extension is running (e.g., SSH from Linux to Windows machine).
 		// Since the CWD is expected to be an absolute path in the debugger's environment, we can test
 		// that to determine the path type used by the debugger and use the result of that test to
 		// select the correct API to check whether the target path is an absolute path.
@@ -215,7 +215,7 @@ export class MI2 extends EventEmitter implements IBackend {
 			cmds.push(this.sendCommand("file-exec-and-symbols \"" + escape(target) + "\""));
 		if (this.prettyPrint)
 			cmds.push(this.sendCommand("enable-pretty-printing"));
-		for (let cmd of this.extraCommands) {
+		for (const cmd of this.extraCommands) {
 			cmds.push(this.sendCommand(cmd));
 		}
 
@@ -374,7 +374,7 @@ export class MI2 extends EventEmitter implements IBackend {
 											this.emit("watchpoint", parsed);
 											break;
 										case "function-finished":
-											// identical result -> send step-end
+											// identical result → send step-end
 											// this.emit("step-out-end", parsed);
 											// break;
 										case "location-reached":
@@ -391,7 +391,7 @@ export class MI2 extends EventEmitter implements IBackend {
 										case "fork":
 										case "vfork":
 										case "exec":
-											// TODO: inform the user, possibly add second inferiour
+											// TODO: inform the user, possibly add second inferior
 											this.emit("step-end", parsed);
 											break;
 										case "signal-received":
@@ -406,7 +406,7 @@ export class MI2 extends EventEmitter implements IBackend {
 											break;
 										// case "exited-signalled":	// consider handling that explicit possible
 										// 	this.log("stderr", "Program exited because of signal " + parsed.record("signal"));
-										// 	this.emit("stoped", parsed);
+										// 	this.emit("stopped", parsed);
 										// 	break;
 
 										default:

src/backend/mi2/mi2lldb.ts

@@ -29,7 +29,7 @@ export class MI2_LLDB extends MI2 {
 		];
 		if (!attach)
 			cmds.push(this.sendCommand("file-exec-and-symbols \"" + escape(target) + "\""));
-		for (let cmd of this.extraCommands) {
+		for (const cmd of this.extraCommands) {
 			cmds.push(this.sendCliCommand(cmd));
 		}
 		return cmds;
@@ -64,7 +64,7 @@ export class MI2_LLDB extends MI2 {
 			// LLDB doesn't allow quoting the whole argument but rather only the file
 			const target: string = (filename ? '"' + escape(filename) + '":' : "") + line;
 			this.sendCliCommand("jump " + target).then(() => {
-				this.emit("step-other", null);
+				this.emit("step-other", undefined);
 				resolve(true);
 			}, reject);
 		});

src/frontend/extension.ts

@@ -111,14 +111,14 @@ class MemoryContentProvider implements vscode.TextDocumentContentProvider {
 			conn.write("examineMemory " + JSON.stringify([from, to - from + 1]));
 			conn.once("data", data => {
 				let formattedCode = "                  00 01 02 03 04 05 06 07  08 09 0A 0B 0C 0D 0E 0F\n";
-				var index: number = from;
+				let index: number = from;
 				const hexString = data.toString();
 				let x = 0;
 				let asciiLine = "";
 				let byteNo = 0;
 				for (let i = 0; i < hexString.length; i += 2) {
 					if (x == 0) {
-						var addr = index.toString(16);
+						let addr = index.toString(16);
 						while (addr.length < 16) addr = '0' + addr;
 						formattedCode += addr + "  ";
 					}
@@ -165,7 +165,7 @@ class MemoryContentProvider implements vscode.TextDocumentContentProvider {
 }
 
 function center(str: string, width: number): string {
-	var left = true;
+	let left = true;
 	while (str.length < width) {
 		if (left) str = ' ' + str;
 		else str = str + ' ';

src/gdb.ts

@@ -165,7 +165,7 @@ class GDBDebugSession extends MI2DebugSession {
 		if (substitutions) {
 			Object.keys(substitutions).forEach(source => {
 				this.miDebugger.extraCommands.push("gdb-set substitute-path \"" + escape(source) + "\" \"" + escape(substitutions[source]) + "\"");
-			})
+			});
 		}
 	}
 }

src/lldb.ts

@@ -118,7 +118,7 @@ class LLDBDebugSession extends MI2DebugSession {
 		if (substitutions) {
 			Object.keys(substitutions).forEach(source => {
 				this.miDebugger.extraCommands.push("settings append target.source-map " + source + " " + substitutions[source]);
-			})
+			});
 		}
 	}
 }

src/mibase.ts

@@ -57,7 +57,7 @@ export class MI2DebugSession extends DebugSession {
 		this.miDebugger.on("breakpoint", this.handleBreakpoint.bind(this));
 		this.miDebugger.on("watchpoint", this.handleBreak.bind(this));	// consider to parse old/new, too (otherwise it is in the console only)
 		this.miDebugger.on("step-end", this.handleBreak.bind(this));
-		// this.miDebugger.on("step-out-end", this.handleBreak.bind(this));  // was combined into step-end
+		//this.miDebugger.on("step-out-end", this.handleBreak.bind(this));  // was combined into step-end
 		this.miDebugger.on("step-other", this.handleBreak.bind(this));
 		this.miDebugger.on("signal-stop", this.handlePause.bind(this));
 		this.miDebugger.on("thread-created", this.threadCreatedEvent.bind(this));
@@ -159,6 +159,7 @@ export class MI2DebugSession extends DebugSession {
 
 		if (this.serverPath)
 			fs.unlink(this.serverPath, (err) => {
+				// tslint:disable-next-line: no-console
 				console.error("Failed to unlink debug server");
 			});
 	}
@@ -266,7 +267,7 @@ export class MI2DebugSession extends DebugSession {
 					threads: []
 				};
 				for (const thread of threads) {
-					let threadName = thread.name || thread.targetId || "<unnamed>";
+					const threadName = thread.name || thread.targetId || "<unnamed>";
 					response.body.threads.push(new Thread(thread.id, thread.id + ":" + threadName));
 				}
 				this.sendResponse(response);
@@ -353,7 +354,7 @@ export class MI2DebugSession extends DebugSession {
 					//
 					// If we don't send this event, the client may start requesting data (such as
 					// stack frames, local variables, etc.) since they believe the target is
-					// stopped.  Furthermore the client may not be indicating the proper status
+					// stopped.  Furthermore, the client may not be indicating the proper status
 					// to the user (may indicate stopped when the target is actually running).
 					this.sendEvent(new ContinuedEvent(1, true));
 				}));
@@ -392,7 +393,7 @@ export class MI2DebugSession extends DebugSession {
 		const createScope = (scopeName: string, expensive: boolean): Scope => {
 			const key: string = scopeName + ":" + threadId + ":" + level;
 			let handle: number;
-			
+
 			if (this.scopeHandlesReverse.hasOwnProperty(key)) {
 				handle = this.scopeHandlesReverse[key];
 			} else {
@@ -401,7 +402,7 @@ export class MI2DebugSession extends DebugSession {
 			}
 
 			return new Scope(scopeName, handle, expensive);
-		}
+		};
 
 		scopes.push(createScope("Local", false));
 
@@ -505,7 +506,7 @@ export class MI2DebugSession extends DebugSession {
 			// Variable members
 			let variable;
 			try {
-				// TODO: this evals on an (effectively) unknown thread for multithreaded programs.
+				// TODO: this evaluates on an (effectively) unknown thread for multithreaded programs.
 				variable = await this.miDebugger.evalExpression(JSON.stringify(id), 0, 0);
 				try {
 					let expanded = expandValue(createVariable, variable.result("value"), id, variable);
@@ -563,7 +564,7 @@ export class MI2DebugSession extends DebugSession {
 						this.sendResponse(response);
 					};
 					const addOne = async () => {
-						// TODO: this evals on an (effectively) unknown thread for multithreaded programs.
+						// TODO: this evaluates on an (effectively) unknown thread for multithreaded programs.
 						const variable = await this.miDebugger.evalExpression(JSON.stringify(`${varReq.name}+${arrIndex})`), 0, 0);
 						try {
 							const expanded = expandValue(createVariable, variable.result("value"), varReq.name, variable);
@@ -709,7 +710,7 @@ export class MI2DebugSession extends DebugSession {
 
 	protected gotoTargetsRequest(response: DebugProtocol.GotoTargetsResponse, args: DebugProtocol.GotoTargetsArguments): void {
 		const path: string = this.isSSH ? this.sourceFileMap.toRemotePath(args.source.path) : args.source.path;
-+		this.miDebugger.goto(path, args.line).then(done => {
+		this.miDebugger.goto(path, args.line).then(done => {
 			response.body = {
 				targets: [{
 					id: 1,

src/test/runTest.ts

@@ -1,24 +1,25 @@
 import * as path from 'path';
 
 import { runTests } from 'vscode-test';
+// tslint:disable: no-console
 
 async function main() {
-  try {
-    // The folder containing the Extension Manifest package.json
-    // Passed to `--extensionDevelopmentPath`
-    const extensionDevelopmentPath = path.resolve(__dirname, '../../');
+	try {
+// The folder containing the Extension Manifest package.json
+		// Passed to `--extensionDevelopmentPath`
+		const extensionDevelopmentPath = path.resolve(__dirname, '../../');
 
-    // The path to the extension test runner script
-    // Passed to --extensionTestsPath
-    const extensionTestsPath = path.resolve(__dirname, './suite/index');
+		// The path to the extension test runner script
+		// Passed to `--extensionTestsPath`
+		const extensionTestsPath = path.resolve(__dirname, './suite/index');
 
-    // Download VS Code, unzip it and run the integration test
-    await runTests({ extensionDevelopmentPath, extensionTestsPath });
-  } catch (err) {
-    console.error(err);
-    console.error('Failed to run tests');
-    process.exit(1);
-  }
+		// Download VS Code, unzip it and run the integration test
+		await runTests({ extensionDevelopmentPath, extensionTestsPath });
+	} catch (err) {
+		console.error(err);
+		console.error('Failed to run tests');
+		process.exit(1);
+	}
 }
 
-main();
+main();

src/test/suite/index.ts

@@ -3,35 +3,35 @@ import * as Mocha from 'mocha';
 import * as glob from 'glob';
 
 export function run(): Promise<void> {
-  // Create the mocha test
-  const mocha = new Mocha({
-    ui: 'tdd',
-    useColors: true
-  });
+	// Create the mocha test
+	const mocha = new Mocha({
+		ui: 'tdd',
+		useColors: true
+	});
 
-  const testsRoot = path.resolve(__dirname, '..');
+	const testsRoot = path.resolve(__dirname, '..');
 
-  return new Promise((c, e) => {
-    glob('**/**.test.js', { cwd: testsRoot }, (err, files) => {
-      if (err) {
-        return e(err);
-      }
+	return new Promise((c, e) => {
+		glob('**/**.test.js', { cwd: testsRoot }, (err, files) => {
+			if (err) {
+				return e(err);
+			}
 
-      // Add files to the test suite
-      files.forEach(f => mocha.addFile(path.resolve(testsRoot, f)));
+			// Add files to the test suite
+			files.forEach(f => mocha.addFile(path.resolve(testsRoot, f)));
 
-      try {
-        // Run the mocha test
-        mocha.run(failures => {
-          if (failures > 0) {
-            e(new Error(`${failures} tests failed.`));
-          } else {
-            c();
-          }
-        });
-      } catch (err) {
-        e(err);
-      }
-    });
-  });
-}
+			try {
+				// Run the mocha test
+				mocha.run(failures => {
+					if (failures > 0) {
+						e(new Error(`${failures} tests failed.`));
+					} else {
+						c();
+					}
+				});
+			} catch (err) {
+				e(err);
+			}
+		});
+	});
+}

src/test/suite/mi_parse.test.ts

@@ -191,7 +191,7 @@ suite("MI Parse", () => {
 	test("empty string value first and last", () => {
 		const parsed = parseMI(`15^done,register-names=["","r0","pc","","xpsr","","control",""]`);
 		const result = parsed.result('register-names');
-		assert.deepEqual(result, ["","r0","pc","","xpsr","","control", ""]);
+		assert.deepEqual(result, ["", "r0", "pc", "", "xpsr", "", "control", ""]);
 	});
 	test("empty array values", () => {
 		const parsed = parseMI(`15^done,foo={x=[],y="y"}`);