Merge pull request #5 from Wikia/REL1_39

PLATFORM-7870 |  remove deprecated code for MW1.39

Author: MrVanosh

classes/PvXCode.php

@@ -24,12 +24,13 @@ class PvXCode {
 	public static function parserRender( string $input, array $args, Parser $parser, string $frame ) {
 		$parser->getOutput()->addModuleStyles( 'ext.PvXCode.css' );
 		$parser->getOutput()->addModules( 'ext.PvXCode.js' );
-		$title = $parser->getTitle()->getText();
+		$title = TitleValue::newFromPage( $parser->getPage() );
+		$text = $title->getText();
 
 		// Using recursiveTagParse() instead of parse() to avoid wrapping result
 		// in a div and the associated processing time hidden HTML comment
 		$parsed_input = $parser->recursiveTagParse( $input, $frame = false );
 
-		return parseGwbbcode( $parsed_input, $title );
+		return parseGwbbcode( $parsed_input, $text );
 	}
 }

gwbbcode/gwbbcode.inc.php

@@ -1557,13 +1557,13 @@ function add_strength( $desc, &$extra_desc, $attr_list, $type ) {
 	if ( isset( $attr_list['Strength'] ) && $attr_list['Strength'] > 0 && strpos( $type, 'Attack' ) !== false ) {
 		// Strength does not stack with skills with inherent armor penetration
 		if ( preg_match( '@[Tt]his (attack|axe attack) has ([0-9]+)% armor penetration@', $desc, $reg ) ) {
-			if ( $reg[2] < $strength ) {
+			if ( $reg[2] < $attr_list['Strength']  ) {
 				$extra_desc =
-					'This attack skill has <b>' . $strength .
+					'This attack skill has <b>' . $attr_list['Strength'] .
 					'</b>% armor penetration. Its inherent armor penetration is overwritten.';
 			}
 		} else {
-			$extra_desc = 'This attack skill has <b>' . $strength . '</b>% armor penetration.';
+			$extra_desc = 'This attack skill has <b>' . $attr_list['Strength'] . '</b>% armor penetration.';
 		}
 	}
 }

specials/SpecialPvXDecode.php

@@ -1,5 +1,6 @@
 <?php
 
+
 /**
  * Curse Inc.
  * PvX Code
@@ -22,7 +23,6 @@ class SpecialPvXDecode extends SpecialPage {
 	 */
 	public function __construct() {
 		parent::__construct( 'PvXDecode' );
-		$this->DB = wfGetDB( DB_PRIMARY );
 
 		require_once( GWBBCODE_ROOT . '/gwbbcode.inc.php' );
 	}
@@ -84,4 +84,4 @@ protected function getGroupName(): string {
 		// Change to display in a different category on Special:SpecialPages.
 		return 'pvx';
 	}
-}
+}