Merge pull request #612 from WillCodeForCats/code-quality

Only log battery energy warning once per occurrence

Author: WillCodeForCats

custom_components/solaredge_modbus_multi/sensor.py

@@ -1932,6 +1932,7 @@ def __init__(self, platform, config_entry, coordinator):
 
         self._last = None
         self._count = 0
+        self._log_once = None
 
     @property
     def unique_id(self) -> str:
@@ -1959,21 +1960,26 @@ def native_value(self):
 
                     if self._platform.decoded_model["B_Export_Energy_WH"] >= self._last:
                         self._last = self._platform.decoded_model["B_Export_Energy_WH"]
+                        self._log_once = False
 
                         if self._platform.allow_battery_energy_reset:
                             self._count = 0
 
                         return self._platform.decoded_model["B_Export_Energy_WH"]
 
                     else:
-                        if not self._platform.allow_battery_energy_reset:
+                        if (
+                            not self._platform.allow_battery_energy_reset
+                            and not self._log_once
+                        ):
                             _LOGGER.warning(
                                 (
                                     "Battery Export Energy went backwards: Current value "  # noqa: B950
                                     f"{self._platform.decoded_model['B_Export_Energy_WH']} "  # noqa: B950
                                     f"is less than last value of {self._last}"
                                 )
                             )
+                            self._log_once = True
 
                         if self._platform.allow_battery_energy_reset:
                             self._count += 1
@@ -2015,6 +2021,7 @@ def __init__(self, platform, config_entry, coordinator):
 
         self._last = None
         self._count = 0
+        self._log_once = None
 
     @property
     def unique_id(self) -> str:
@@ -2042,21 +2049,26 @@ def native_value(self):
 
                     if self._platform.decoded_model["B_Import_Energy_WH"] >= self._last:
                         self._last = self._platform.decoded_model["B_Import_Energy_WH"]
+                        self._log_once = False
 
                         if self._platform.allow_battery_energy_reset:
                             self._count = 0
 
                         return self._platform.decoded_model["B_Import_Energy_WH"]
 
                     else:
-                        if not self._platform.allow_battery_energy_reset:
+                        if (
+                            not self._platform.allow_battery_energy_reset
+                            and not self._log_once
+                        ):
                             _LOGGER.warning(
                                 (
                                     "Battery Import Energy went backwards: Current value "  # noqa: B950
                                     f"{self._platform.decoded_model['B_Import_Energy_WH']} "  # noqa: B950
                                     f"is less than last value of {self._last}"
                                 )
                             )
+                            self._log_once = True
 
                         if self._platform.allow_battery_energy_reset:
                             self._count += 1