Skip to content

Commit a8d0dcc

Browse files
authored
Merge pull request GoogleCloudPlatform#523 from donmccasland/fix-tests
Fixing tests for 5.6 and 7.0
2 parents a0e5755 + a6c12f8 commit a8d0dcc

File tree

1 file changed

+0
-28
lines changed

1 file changed

+0
-28
lines changed

builder/gen-dockerfile/tests/GenFilesCommandTest.php

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,6 @@ public function testGenFilesCommand(
7676
if ($baseImages === null) {
7777
$baseImages =
7878
[
79-
'--php56-image' => 'gcr.io/google-appengine/php56:latest',
80-
'--php70-image' => 'gcr.io/google-appengine/php70:latest',
8179
'--php71-image' => 'gcr.io/google-appengine/php71:latest',
8280
'--php72-image' => 'gcr.io/google-appengine/php72:latest',
8381
'--php73-image' => 'gcr.io/google-appengine/php73:latest',
@@ -188,32 +186,6 @@ public function dataProvider()
188186
[],
189187
'\\Google\\Cloud\\Runtimes\\Builder\\Exception\\InvalidComposerFlagsException'
190188
],
191-
[
192-
// PHP 5.6
193-
__DIR__ . '/test_data/php56',
194-
null,
195-
'',
196-
'/app',
197-
'added by the php runtime builder',
198-
'gcr.io/google-appengine/php56:latest',
199-
["COMPOSER_FLAGS='--no-dev --prefer-dist' \\\n",
200-
"FRONT_CONTROLLER_FILE='index.php' \\\n",
201-
"DETECTED_PHP_VERSION='5.6' \n"
202-
]
203-
],
204-
[
205-
// PHP 7.0
206-
__DIR__ . '/test_data/php70',
207-
null,
208-
'',
209-
'/app',
210-
'added by the php runtime builder',
211-
'gcr.io/google-appengine/php70:latest',
212-
["COMPOSER_FLAGS='--no-dev --prefer-dist' \\\n",
213-
"FRONT_CONTROLLER_FILE='index.php' \\\n",
214-
"DETECTED_PHP_VERSION='7.0' \n"
215-
]
216-
],
217189
[
218190
// PHP 7.1
219191
__DIR__ . '/test_data/php71',

0 commit comments

Comments
 (0)