Fixes the problem when the aspect ratio is less than 1, that the sele…

…ction has an incorrect resolution
WoltLab · Dec 6, 2024 · a9d93bf · a9d93bf
1 parent 9ad0476
commit a9d93bf
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/ts/WoltLabSuite/Core/Component/Image/Cropper.ts b/ts/WoltLabSuite/Core/Component/Image/Cropper.ts
@@ -372,10 +372,13 @@ class MinMaxImageCropper extends ImageCropper {
 
   protected centerSelection(): void {
     this.cropperImage!.$center("contain");
+    this.#cropperCanvasRect = this.cropperImage!.getBoundingClientRect();
 
-    const { width: imageWidth } = this.cropperImage!.getBoundingClientRect();
-
-    this.cropperSelection!.$change(0, 0, imageWidth, 0, this.configuration.aspectRatio, true);
+    if (this.configuration.aspectRatio >= 1.0) {
+      this.cropperSelection!.$change(0, 0, this.#cropperCanvasRect.width, 0, this.configuration.aspectRatio, true);
+    } else {
+      this.cropperSelection!.$change(0, 0, 0, this.#cropperCanvasRect.height, this.configuration.aspectRatio, true);
+    }
     this.cropperSelection!.$center();
     this.cropperSelection!.scrollIntoView({ block: "center", inline: "center" });
   }

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Component/Image/Cropper.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Component/Image/Cropper.js