Merge pull request go-git#117 from cristaloleg/fix-goreportcard

fix goreportcard warnings

Author: mcuadros

blame_test.go

@@ -4,8 +4,8 @@ import (
 	"github.com/go-git/go-git/v5/plumbing"
 	"github.com/go-git/go-git/v5/plumbing/object"
 
+	fixtures "github.com/go-git/go-git-fixtures/v4"
 	. "gopkg.in/check.v1"
-	"github.com/go-git/go-git-fixtures/v4"
 )
 
 type BlameSuite struct {

config/branch_test.go

@@ -1,8 +1,9 @@
 package config
 
 import (
-	. "gopkg.in/check.v1"
 	"github.com/go-git/go-git/v5/plumbing"
+
+	. "gopkg.in/check.v1"
 )
 
 type BranchSuite struct{}

internal/revision/parser_test.go

@@ -96,8 +96,8 @@ func (s *ParserSuite) TestParseWithValidExpression(c *C) {
 			TildePath{3},
 		},
 		"@{2016-12-16T21:42:47Z}": []Revisioner{AtDate{tim}},
-		"@{1}":  []Revisioner{AtReflog{1}},
-		"@{-1}": []Revisioner{AtCheckout{1}},
+		"@{1}":                    []Revisioner{AtReflog{1}},
+		"@{-1}":                   []Revisioner{AtCheckout{1}},
 		"master@{upstream}": []Revisioner{
 			Ref("master"),
 			AtUpstream{},
@@ -211,12 +211,12 @@ func (s *ParserSuite) TestParseAtWithValidExpression(c *C) {
 	tim, _ := time.Parse("2006-01-02T15:04:05Z", "2016-12-16T21:42:47Z")
 
 	datas := map[string]Revisioner{
-		"":           Ref("HEAD"),
-		"{1}":        AtReflog{1},
-		"{-1}":       AtCheckout{1},
-		"{push}":     AtPush{},
-		"{upstream}": AtUpstream{},
-		"{u}":        AtUpstream{},
+		"":                       Ref("HEAD"),
+		"{1}":                    AtReflog{1},
+		"{-1}":                   AtCheckout{1},
+		"{push}":                 AtPush{},
+		"{upstream}":             AtUpstream{},
+		"{u}":                    AtUpstream{},
 		"{2016-12-16T21:42:47Z}": AtDate{tim},
 	}
 

plumbing/format/commitgraph/commitgraph_test.go

@@ -6,10 +6,11 @@ import (
 	"path"
 	"testing"
 
-	. "gopkg.in/check.v1"
-	fixtures "github.com/go-git/go-git-fixtures/v4"
 	"github.com/go-git/go-git/v5/plumbing"
 	"github.com/go-git/go-git/v5/plumbing/format/commitgraph"
+
+	fixtures "github.com/go-git/go-git-fixtures/v4"
+	. "gopkg.in/check.v1"
 )
 
 func Test(t *testing.T) { TestingT(t) }

plumbing/format/idxfile/encoder_test.go

@@ -6,8 +6,8 @@ import (
 
 	. "github.com/go-git/go-git/v5/plumbing/format/idxfile"
 
+	fixtures "github.com/go-git/go-git-fixtures/v4"
 	. "gopkg.in/check.v1"
-	"github.com/go-git/go-git-fixtures/v4"
 )
 
 func (s *IdxfileSuite) TestDecodeEncode(c *C) {

plumbing/format/idxfile/idxfile_test.go

@@ -10,8 +10,8 @@ import (
 	"github.com/go-git/go-git/v5/plumbing"
 	"github.com/go-git/go-git/v5/plumbing/format/idxfile"
 
+	fixtures "github.com/go-git/go-git-fixtures/v4"
 	. "gopkg.in/check.v1"
-	"github.com/go-git/go-git-fixtures/v4"
 )
 
 func BenchmarkFindOffset(b *testing.B) {

plumbing/format/idxfile/writer_test.go

@@ -9,8 +9,8 @@ import (
 	"github.com/go-git/go-git/v5/plumbing/format/idxfile"
 	"github.com/go-git/go-git/v5/plumbing/format/packfile"
 
+	fixtures "github.com/go-git/go-git-fixtures/v4"
 	. "gopkg.in/check.v1"
-	"github.com/go-git/go-git-fixtures/v4"
 )
 
 type WriterSuite struct {

plumbing/format/index/decoder.go

@@ -390,7 +390,9 @@ func (d *treeExtensionDecoder) readEntry() (*TreeEntry, error) {
 
 	e.Trees = i
 	_, err = io.ReadFull(d.r, e.Hash[:])
-
+	if err != nil {
+		return nil, err
+	}
 	return e, nil
 }
 

plumbing/format/index/decoder_test.go

@@ -6,8 +6,8 @@ import (
 	"github.com/go-git/go-git/v5/plumbing"
 	"github.com/go-git/go-git/v5/plumbing/filemode"
 
+	fixtures "github.com/go-git/go-git-fixtures/v4"
 	. "gopkg.in/check.v1"
-	"github.com/go-git/go-git-fixtures/v4"
 )
 
 func Test(t *testing.T) { TestingT(t) }

plumbing/format/index/encoder_test.go

@@ -5,9 +5,10 @@ import (
 	"strings"
 	"time"
 
+	"github.com/go-git/go-git/v5/plumbing"
+
 	"github.com/google/go-cmp/cmp"
 	. "gopkg.in/check.v1"
-	"github.com/go-git/go-git/v5/plumbing"
 )
 
 func (s *IndexSuite) TestEncode(c *C) {