Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENUM attributes: Those intended to be translated to components do not convert as intended #75

Open
mgrbyte opened this issue May 26, 2017 · 2 comments
Assignees
Labels

Comments

@mgrbyte
Copy link
Contributor

mgrbyte commented May 26, 2017

When a ENUM tag in the annotated ACeDB models is marked with a hash-model (e.g #Evidence), the data is not migrated since the ENUM will result in an ident, which is not a referenable construct (in it's own right) in datomic (i.e it is a :db.type/keyword not a :db.type/ref)
The example cited that @a8wright ran into recently was :molecule.biofunction-role/value, whose annotated source is here,

The result (datomic entity api usage shown below in a clojure REPL session):

pseudoace.cli=> (->> mol :molecule/biofunction-role (map d/touch)
           #_=> )
({:db/id 12134210419605054, :molecule.biofunction-role/value :molecule.biofunction-role.value/metabolite, :molecule.biofunction-role/text "Paper_evidence"})
@mgrbyte mgrbyte added the bug label May 26, 2017
@mgrbyte mgrbyte self-assigned this May 26, 2017
@mgrbyte
Copy link
Contributor Author

mgrbyte commented May 26, 2017

Requires re-working the construct used in the annotated models not to use ENUM if the data captured in #Evidence needs to be maintained, or otherwise solved by re-modelling.

@mgrbyte
Copy link
Contributor Author

mgrbyte commented Jun 15, 2017

Updates on this:

https://github.com/WormBase/website/issues/5687
WormBase/wormbase-pipeline#61 (comment)

Headline: only some usage of ENUM are effected; those where the enumerated value is followed with both a reference and a hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant