Merge remote-tracking branch 'upstream/master'

Author: WulfgarW

.github/ISSUE_TEMPLATE/bug_report.yaml

@@ -39,9 +39,9 @@ body:
       render: yaml
       description: >
         Show evcc configuration file <code>evcc.yaml</code>
-        
+
         Please make sure your report does NOT contain **passwords**, **sponsor token** or other **credentials**!
-        
+
         To quickly dump a redacted configuration without secrets, you can use the `evcc dump --cfg` command.
 
   - type: textarea
@@ -69,6 +69,15 @@ body:
         - macOS
         - other
 
+  - type: checkboxes
+    id: external
+    attributes:
+      label: External automation
+      description: Make sure the observed issue is caused by evcc and not by external automation
+      options:
+        - label: I have made sure that no external automation like HomeAssistant or Node-RED is active or accessing any of the mentioned devices when this issue occurs.
+          required: true
+
   - type: checkboxes
     id: nightly
     attributes:

.github/workflows/default.yml

@@ -1,8 +1,5 @@
 name: Default
 
-env:
-  GO_VERSION: ^1.23
-
 on:
   push:
     branches:
@@ -13,14 +10,13 @@ on:
 jobs:
   clean:
     name: Clean
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
 
     steps:
       - uses: actions/checkout@v4
 
       - uses: actions/setup-go@v5
         with:
-          go-version: ${{ env.GO_VERSION }}
           cache: false
         id: go
 
@@ -58,7 +54,6 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: ${{ env.GO_VERSION }}
           cache: false
         id: go
 
@@ -91,7 +86,6 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: ${{ env.GO_VERSION }}
           cache: false
         id: go
 
@@ -117,7 +111,6 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: ${{ env.GO_VERSION }}
           cache: false # avoid cache thrashing
         id: go
 
@@ -183,7 +176,6 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: ${{ env.GO_VERSION }}
           cache: false
         id: go
 
@@ -208,14 +200,12 @@ jobs:
       - name: Build Go
         run: make build
 
+      - name: Install Playwright
+        run: npx playwright install --with-deps chromium
+
       - name: Run tests
         run: npx playwright test
 
-      # - name: Run tests
-      #   uses: docker://mcr.microsoft.com/playwright:v1.34.3-jammy
-      #   with:
-      #     args: npx playwright test
-
       - uses: actions/upload-artifact@v4
         if: ${{ !cancelled() }}
         with:

.github/workflows/documentation.yml

@@ -1,8 +1,5 @@
 name: Deploy updated templates
 
-env:
-  GO_VERSION: ^1.23
-
 on:
   schedule:
     - cron: "0 2 * * *" # same time as nightly is triggered
@@ -19,8 +16,6 @@ jobs:
       - uses: actions/checkout@v4
 
       - uses: actions/setup-go@v5
-        with:
-          go-version: ${{ env.GO_VERSION }}
         id: go
 
       - name: Build docs

.github/workflows/nightly.yml

@@ -1,8 +1,5 @@
 name: Nightly Build
 
-env:
-  GO_VERSION: ^1.23
-
 on:
   schedule: # runs on the default branch: master
     - cron: "0 2 * * *" # run at 2 AM UTC
@@ -62,14 +59,59 @@ jobs:
       - name: Setup Buildx
         uses: docker/setup-buildx-action@v3
 
+      - name: Define tags
+        id: meta
+        uses: docker/metadata-action@v5
+        with:
+          images: evcc/evcc
+          tags: |
+            type=raw,value=nightly
+            type=raw,value=nightly.{{date 'YYYYMMDD'}}-{{sha}}
+
       - name: Publish
         uses: docker/build-push-action@v6
         with:
           context: .
           platforms: linux/amd64,linux/arm64,linux/arm/v6
           push: true
-          tags: |
-            evcc/evcc:nightly
+          tags: ${{ steps.meta.outputs.tags }}
+
+      - name: Delete old nightly.* tags
+        run: |
+          old_tags=$(curl -s "https://hub.docker.com/v2/repositories/evcc/evcc/tags/?page_size=100" | jq -r '.results | map(select(.name | startswith("nightly."))) | sort_by(.last_updated) | reverse | .[1:] | .[].name')
+          for tag in $old_tags; do
+            echo "Deleting tag: $tag"
+            curl -s -H "Authorization: Bearer ${{ secrets.DOCKER_PASS }}" -X DELETE "https://hub.docker.com/v2/repositories/evcc/evcc/tags/$tag/"
+          done
+
+  hassio:
+    name: Hassio Addon :nightly
+    needs:
+      - docker
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@master
+        with:
+          repository: evcc-io/hassio-addon
+          token: ${{ secrets.GH_TOKEN }}
+          path: ./hassio
+
+      - name: Update version
+        run: |
+          current_date=$(date +%Y%m%d)
+          short_sha=$(echo "${{ github.sha }}" | cut -c 1-7)
+          sed -i -e "s/version:.*/version: nightly.${current_date}-${short_sha}/" ./hassio/evcc-nightly/config.yaml
+
+      - name: Push
+        run: |
+          cd ./hassio
+          git add .
+          git config user.name github-actions
+          git config user.email [email protected]
+          git commit -am "Mirror evcc nightly release"
+          git push
 
   apt:
     name: Publish APT nightly
@@ -83,8 +125,6 @@ jobs:
           fetch-depth: 0
 
       - uses: actions/setup-go@v5
-        with:
-          go-version: ${{ env.GO_VERSION }}
         id: go
 
       - name: Patch ASN1

.github/workflows/release.yml

@@ -1,8 +1,5 @@
 name: Release
 
-env:
-  GO_VERSION: ^1.23
-
 on:
   push:
     tags:
@@ -63,8 +60,6 @@ jobs:
 
       - name: Setup Go
         uses: actions/setup-go@v5
-        with:
-          go-version: ${{ env.GO_VERSION }}
         id: go
 
       - name: Patch ASN1

.github/workflows/website.yml

@@ -1,8 +1,5 @@
 name: Deploy data to website
 
-env:
-  GO_VERSION: ^1.23
-
 on:
   release:
     types: [created]
@@ -17,8 +14,6 @@ jobs:
       - uses: actions/checkout@v4
 
       - uses: actions/setup-go@v5
-        with:
-          go-version: ${{ env.GO_VERSION }}
         id: go
 
       - name: Build docs

.golangci.yml

@@ -1,5 +1,5 @@
 run:
-  go: "1.23"
+  go: "1.24"
 
 issues:
   exclude:

.goreleaser-nightly.yml

@@ -33,14 +33,6 @@ builds:
         flags:
           - -trimpath
           - -tags=release,timetzdata
-      - goos: darwin
-        goarch: arm64
-        ldflags:
-          - -X github.com/evcc-io/evcc/server.Version={{ .Tag }} -X github.com/evcc-io/evcc/server.Commit={{ .ShortCommit }} -s -w -B gobuildid
-      - goos: darwin
-        goarch: amd64
-        ldflags:
-          - -X github.com/evcc-io/evcc/server.Version={{ .Tag }} -X github.com/evcc-io/evcc/server.Commit={{ .ShortCommit }} -s -w -B gobuildid
 
 archives:
   - builds:

.goreleaser.yml

@@ -38,14 +38,6 @@ builds:
         flags:
           - -trimpath
           - -tags=release,timetzdata
-      - goos: darwin
-        goarch: arm64
-        ldflags:
-          - -X github.com/evcc-io/evcc/server.Version={{ .Version }} -s -w -B gobuildid
-      - goos: darwin
-        goarch: amd64
-        ldflags:
-          - -X github.com/evcc-io/evcc/server.Version={{ .Version }} -s -w -B gobuildid
 
 env:
   - CGO_ENABLED=0

CONTRIBUTING.md

@@ -4,7 +4,7 @@
 
 #### Development environment
 
-Developing evcc requires [Go][1] 1.23 and [Node][2] 22. We recommend VSCode with the [Go](https://marketplace.visualstudio.com/items?itemName=golang.Go), [Prettier](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode) and [Vetur](https://marketplace.visualstudio.com/items?itemName=octref.vetur) extensions.
+Developing evcc requires [Go][1] and [Node][2]. We recommend VSCode with the [Go](https://marketplace.visualstudio.com/items?itemName=golang.Go), [Prettier](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode) and [Vetur](https://marketplace.visualstudio.com/items?itemName=octref.vetur) extensions.
 
 Alternatively, if you use VS Code and [devcontainers](https://code.visualstudio.com/docs/devcontainers/containers), you can use the "Dev containers: Clone repository in container volume" action. This will create a devcontainer with the required toolchain and install the prerequisites as explained below. Wait until the startup log says "Done. Press any key to close the terminal." and check for any errors.
 

Dockerfile

@@ -20,7 +20,7 @@ RUN make ui
 
 
 # STEP 2 build executable binary
-FROM --platform=$BUILDPLATFORM golang:1.23-alpine AS builder
+FROM --platform=$BUILDPLATFORM golang:1.24-alpine AS builder
 
 # Install git + SSL ca certificates.
 # Git is required for fetching the dependencies.
@@ -39,7 +39,6 @@ RUN go mod download
 
 # install tools
 COPY Makefile .
-COPY tools.go .
 COPY cmd/decorate/ cmd/decorate/
 COPY api/ api/
 RUN make install
@@ -58,9 +57,6 @@ ARG TARGETARCH
 ARG TARGETVARIANT
 ARG GOARM=${TARGETVARIANT#v}
 
-ARG TESLA_CLIENT_ID
-ENV TESLA_CLIENT_ID=${TESLA_CLIENT_ID}
-
 RUN RELEASE=${RELEASE} GOOS=${TARGETOS} GOARCH=${TARGETARCH} GOARM=${GOARM} make build