From ef17ebaf143ec52d13ebbbd94b35567d81a11770 Mon Sep 17 00:00:00 2001
From: David Szkiba <david.szkiba@wunderbyte.at>
Date: Thu, 7 Nov 2024 15:49:09 +0100
Subject: [PATCH] GH-745 Fix group enrolment

Fix incorrect comparison (group name vs group ID). Also: do not try to
users that are already members.
---
 classes/catquiz.php | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/classes/catquiz.php b/classes/catquiz.php
index d0c3b75e6..cd6cc7c4d 100644
--- a/classes/catquiz.php
+++ b/classes/catquiz.php
@@ -1979,7 +1979,10 @@ public static function enrol_and_create_message_array(
                 $groupsofcourse = groups_get_all_groups($courseid);
                 foreach ($groupsofcourse as $existinggroup) {
                     foreach ($groupstoenrol[$catscaleid] as $newgroup) {
-                        if ($existinggroup->id == $newgroup) {
+                        if ($existinggroup->name == $newgroup) {
+                            if (groups_is_member($existinggroup->id, $userid)) {
+                                continue;
+                            }
                             $groupmember = groups_add_member($existinggroup->id, $userid);
                             if ($groupmember) {
                                 $data = [];