From 5e364f595b8ae24a1bf0da53f334c442645cf25c Mon Sep 17 00:00:00 2001
From: Koreus <koreus@koreus.com>
Date: Tue, 4 Feb 2025 11:06:21 +0000
Subject: [PATCH 1/4] Removed Warning: Undefined array key "subforum"

---
 htdocs/themes/xbootstrap5/modules/newbb/newbb_index.tpl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/themes/xbootstrap5/modules/newbb/newbb_index.tpl b/htdocs/themes/xbootstrap5/modules/newbb/newbb_index.tpl
index bf8576131..864bbd63a 100644
--- a/htdocs/themes/xbootstrap5/modules/newbb/newbb_index.tpl
+++ b/htdocs/themes/xbootstrap5/modules/newbb/newbb_index.tpl
@@ -140,7 +140,7 @@
                         <{foreach item=forum from=$category.forums|default:null}>
                         <div class="row newbb-list-foruns mb10">
                             <div class="col-sm-6 col-md-6">
-                                <{if $forum.subforum}>
+                                <{if $forum.subforum|default:false}>
                                     <div class="<{if $forum.forum_read == 1 }>forum-read<{else}>forum-new2<{/if}> pull-left">
                                         <{$forum.forum_folder}>
                                     </div>
@@ -221,7 +221,7 @@
                                     <{$smarty.const._MD_NEWBB_NOTOPIC}>
                                 <{/if}>
 
-                                <{if $forum.subforum}>
+                                <{if $forum.subforum|default:false}>
                                     <{$smarty.const._MD_NEWBB_SUBFORUMS}><{$img_subforum}>
                                     <{foreach item=subforum from=$forum.subforum|default:null}>
                                     [

From 1a96b0e4d5f33819cf8c2a553333d886dfaaf4a2 Mon Sep 17 00:00:00 2001
From: Koreus <koreus@koreus.com>
Date: Tue, 4 Feb 2025 11:38:48 +0000
Subject: [PATCH 2/4] Fix subforum not expanding

---
 htdocs/themes/xbootstrap5/modules/newbb/newbb_index.tpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/themes/xbootstrap5/modules/newbb/newbb_index.tpl b/htdocs/themes/xbootstrap5/modules/newbb/newbb_index.tpl
index 864bbd63a..3b2b6027a 100644
--- a/htdocs/themes/xbootstrap5/modules/newbb/newbb_index.tpl
+++ b/htdocs/themes/xbootstrap5/modules/newbb/newbb_index.tpl
@@ -123,7 +123,7 @@
                     <{/if}>
                 </div><!-- .panel-heading -->
 
-                <div id="<{$category.cat_element_id}>" class="panel-collapse collapse <{if $subforum_display == 'expand'}>in<{/if}>">
+                <div id="<{$category.cat_element_id}>" class="panel-collapse collapse <{if $subforum_display == 'expand'}>show<{/if}>">
                     <div class="panel-body">
                         <{if $category.forums}>
                             <div class="row hidden-xs">

From 180b597d07a87bb60ef7e0195b644bea90c2bc48 Mon Sep 17 00:00:00 2001
From: Michael Beck <mambax7@users.noreply.github.com>
Date: Tue, 4 Feb 2025 13:13:55 -0500
Subject: [PATCH 3/4] Update newbb_index.tpl

Normally it is better to check for `!empty()`, otherwise it will internally still issue a warning.

If you checking for a particular value, then using something like

`<{if isset($x)  && $x == 5 }>`

works pretty well
---
 htdocs/themes/xbootstrap5/modules/newbb/newbb_index.tpl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/htdocs/themes/xbootstrap5/modules/newbb/newbb_index.tpl b/htdocs/themes/xbootstrap5/modules/newbb/newbb_index.tpl
index 3b2b6027a..6157980e4 100644
--- a/htdocs/themes/xbootstrap5/modules/newbb/newbb_index.tpl
+++ b/htdocs/themes/xbootstrap5/modules/newbb/newbb_index.tpl
@@ -140,7 +140,7 @@
                         <{foreach item=forum from=$category.forums|default:null}>
                         <div class="row newbb-list-foruns mb10">
                             <div class="col-sm-6 col-md-6">
-                                <{if $forum.subforum|default:false}>
+                                <{if !empty($forum.subforum)}>
                                     <div class="<{if $forum.forum_read == 1 }>forum-read<{else}>forum-new2<{/if}> pull-left">
                                         <{$forum.forum_folder}>
                                     </div>
@@ -161,7 +161,7 @@
                                     </a>
                                 <{/if}>
                                 <!-- Forum description -->
-                                <{if $forum.forum_desc|default:'' != ''}>
+                                <{if !empty($forum.forum_desc)}>
                                     <button class="btn btn-primary btn-xs pull-right" data-bs-toggle="modal" data-bs-target="#forumDesc-<{$forum.forum_id}>"><span
                                                 class="fa fa-info-sign"></span></button>
                                     <div class="modal fade" id="forumDesc-<{$forum.forum_id}>" tabindex="-1" role="dialog" aria-labelledby="ForumDescription"
@@ -221,7 +221,7 @@
                                     <{$smarty.const._MD_NEWBB_NOTOPIC}>
                                 <{/if}>
 
-                                <{if $forum.subforum|default:false}>
+                                <{if !empty($forum.subforum)}>
                                     <{$smarty.const._MD_NEWBB_SUBFORUMS}><{$img_subforum}>
                                     <{foreach item=subforum from=$forum.subforum|default:null}>
                                     [

From 20b746fd8ebe0944cdc3d1dfbf110d401e845e6d Mon Sep 17 00:00:00 2001
From: Koreus <koreus@koreus.com>
Date: Tue, 4 Feb 2025 20:10:05 +0000
Subject: [PATCH 4/4] Fix Theme change after editing profile Theme was not
 saved in session, only in database So Xoops was displaying the old theme

---
 htdocs/modules/profile/edituser.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/modules/profile/edituser.php b/htdocs/modules/profile/edituser.php
index 2c194ef14..12295557e 100644
--- a/htdocs/modules/profile/edituser.php
+++ b/htdocs/modules/profile/edituser.php
@@ -82,7 +82,7 @@
         } else {
             $profile->setVar('profile_id', $edituser->getVar('uid'));
             $profile_handler->insert($profile);
-            unset($_SESSION['xoopsUserTheme']);
+            $_SESSION['xoopsUserTheme']=$edituser->getVar('theme');
             redirect_header(XOOPS_URL . '/modules/' . $GLOBALS['xoopsModule']->getVar('dirname', 'n') . '/userinfo.php?uid=' . $edituser->getVar('uid'), 2, _US_PROFUPDATED);
         }
     }