Deprecated code cleanup

[GregMage]

I looked at deprecated code and noticed that we have 23 reports of deprecated code since xoops 2.5.4. Can we now delete this code? Xoops 2.5.4 was released in 2011 (more than 10 years ago). What do you think?

[mambax7]

Since XOOPS 2.5.11 is the last one release supporting anything smaller than PHP 8.x, I would leave it as it is, since we don't know how old are the modules they are using.

However, since XOOPS 2.5.12 will be focused on supporting PHP 8.2, I would remove all the deprecated code there.
And if possible, I would love to see us getting rid of all the old baggage, and take advantage of all the new features of PHP 8.2, of course, if it makes sense, i.e. if there are benefits to us. The last thing that I would like to do is to rewrite old code that it's working just fine, and replace it with some "syntactic sugar" from PHP 8 :)

But it would be up to Richard as a Core Team Leader to decide about it.

[geekwright]

I am cleaning up some of those in work I'm doing on for Smarty3, specifically in XoopsBlock and XoTpl. It that case, maintaining the old deprecated code would be too costly, time wise.

As soon as we ship 2.5.11, we can clear out almost all of the BC stuff, and move forward to PHP 8 and beyond!