[Bug]: Theme not saved in session with modules/profile

[koreus]

XOOPS Version

2.5.12 beta4

PHP Version

8.3

Operating System

Linux

Description

Hi,

When I change the theme in the profile (with modules/profile installed), and save, the new theme is saved in database but not in session.
So Xoops still displays the old theme.
On file /modules/profile/edituser.php , line 85 . I change :
unset($_SESSION['xoopsUserTheme']);
To :
$_SESSION['xoopsUserTheme']=$edituser->getVar('theme');

It works for me and the change takes effect immediately.
Is there any reason for the unset ?

Steps to Reproduce

With module profile installed :

• Edit profile
• Change current theme to another (you must have enabled multiple themes choice in system preferences)
• Save
• The theme doesn't change but if you go back in your profile, it is.

[mambax7]

The easiest way to switch themes instantly is to activate the "Themes" block from the system:

make it visible to groups that you want to be able to switch themes,

and then you can test various themes right there:

I guess, the original Core developers didn't see it as critical or didn't have time for it. If you fix it, please submit a PR for it

Thanks!

[koreus]

I have pushed a new commit in the patch1 PR 20b746f

Should I have submitted a new PR ? I'm stil learning :)

[koreus]

I found out why the theme was not saved in session

function themeSelect() in xoopskernel.php handles it. It expects a $_POST['xoops_theme_select'].
But the form in modules/profile/edituser.php send a $_POST['theme'].
To correct this, we have to replace theme by xoops_theme_select in the column field_name in table xoops_profile_field .