Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially Inaccurate Statistics #12

Open
4 tasks done
toofyspooder opened this issue Feb 21, 2025 · 25 comments
Open
4 tasks done

Potentially Inaccurate Statistics #12

toofyspooder opened this issue Feb 21, 2025 · 25 comments

Comments

@toofyspooder
Copy link

Checklist

  • I have used the search function for OPEN issues to see if someone else has already submitted the same bug report.
  • I have also used the search function for CLOSED issues to see if the problem is already solved and just waiting to be released.
  • I will describe the problem with as much detail as possible.
  • If the bug only to occurs with a certain podcast, I will include the URL of that podcast.

App version

8.7.0, was happening in earlier versions also

Where did you get the app from

Google Play

Android version

14

Device model

Samsung S24 Ultra (SM-S928W)

First occurred

First noticed Feb 19

Steps to reproduce

Marked off episodes of podcasts that were played previously on another app. Checked off to include those durations in statistics. Duration in statistics page does not match what is marked as played.

Expected behaviour

Addition of episode durations for played episodes would be significantly higher.

Current behaviour

Duration only seems to include what has been played in the app and not marked as played.

Logs

        ## Environment

Android version: 14
OS version: 6.1.75-android14-11-29543898-abS928USQS4AYA1
Podcini version: 8.7.0
Model: SM-S928W
Device: e3q
Product: e3qcsx

        No crash report recorded

Statistics page from AntennaPod

Image

Settings For Statistics Page In AntennaPod

Image

Statistics Page From Podcini.X

Image

Settings For Statistics Page In Podcini.X. Have tried checking "All Time" and nothing seems to change. Is not selected when I open settings again.

Image

@XilinJia
Copy link
Owner

How did you transfer the data from other app? Via NextCloud?

@toofyspooder
Copy link
Author

Some were via Nextcloud and some were just manually marking them as played.

@XilinJia
Copy link
Owner

Yes, you are right. episodes simply marked Played without playing are not counted in the statistics. this is an issue.

Currently, it gets all episodes based on "last played time" in the given period to calculate the statistics, but the "last played time" is only set when the episode is being played, and is not set when it's marked Played. AP probably does the latter which I probably did see a good fit and removed it. So I will need to sort this out.

@XilinJia
Copy link
Owner

Actually with AP, when you check "Include marked played" the statistics no longer observe a date period.

This should be fixed in 8.8.1. Introduced a "mark played" time stamp (initialized to "last played time" if available or the date of first launch of this version). The date period is observed, even on Today.

@toofyspooder
Copy link
Author

Updated to 8.8.1 and the Duration and Spent durations did not change. If I go into the filter and select "All time" then the numbers actually go down? The all time selection doesnt stay selected either and if I go back in and select it a second them the durations get lower again. It's odd.

@toofyspooder
Copy link
Author

toofyspooder commented Feb 24, 2025

Updated to 8.8.2, and now 8.9.0 today, and stats seem to be working. It is still different from AP, but not sure why that is. Both have the same episodes marked as play.

They also have different values per podcast for total time played.

Screenshot_20250224_155414_AntennaPod.jpg

Screenshot_20250224_155315_PodciniX.jpgScreenshot_20250224_160027_PodciniX.jpg

@XilinJia
Copy link
Owner

OK, let's keep watching.

@toofyspooder
Copy link
Author

Would it be a useful test to export the AAP database and import it in to Podcini to see what the stats look like?

Or the reverse if possible?

@XilinJia
Copy link
Owner

XilinJia commented Feb 26, 2025

You can try: test to export the AAP database and import it in to Podcini, but not the other way around.

But comparing 2 unknowns wouldn't be very productive. It would be easier just to test in Podcini by playing a new podcast and check on the numbers in the podcast.

@XilinJia
Copy link
Owner

I had "Include marked Played" also include "marked Skipped" (and Passed and Ignored). Skipped probably shouldn't be included there?

@toofyspooder
Copy link
Author

I would think no, just the ones actually played and marked as played be included.

The other statuses imply the episode was never listened to.

@XilinJia
Copy link
Owner

Agree about Skipped. Marking an episode as Passed or Ignored means the same as marking it as Played when you didn't have the options of Passed or Ignored. So currently, I include them in the so-called "marked played". Will make a way to separate them.

@toofyspooder
Copy link
Author

I like the added filter buttons at the top of the stats screen. And especially love the list of played and marked played for each podcast. It still appears something is going on with the addition of duration though.

I marked an episode as played that was roughly 3 hours long and the duration played for that podcast did not change. I tried turning filter on and off but ultimately that didn't work.

I then listened to another episode of a different podcast which is an hour long. And when finished that podcast duration didn't change either.

Starting Durations
Before Marking As Played.jpg

After Marking 3hr Episode Played
After Marking As Played.jpg

After Listening To 1hr Episode
Screenshot_20250307_124455_PodciniX.jpg

@XilinJia
Copy link
Owner

XilinJia commented Mar 8, 2025

When an episode has been played (started), and then you mark it Played (or, Skipped, Passed, Ignored), the statistics count it by its duration, not its played time, regardless when the filter buttons are selected or not.

The filter buttons are only effective on episodes that have not been played (started) and are marked as such.

Is that what you find?

@toofyspooder
Copy link
Author

No unfortunately. I would expect as you have described, that marking an episode as played regarding of how much you listened to it in Podcini it would add the entire duration of that episode to the stats.

Sometimes the number goes up, sometimes down, and more often the duration for that podcast doesn't change. In my experience.

@XilinJia
Copy link
Owner

XilinJia commented Mar 9, 2025

Sometimes the number goes up, sometimes down, and more often the duration for that podcast doesn't change.

What do you really mean by this?

@toofyspooder
Copy link
Author

On the most recent screenshots, if you look at the "Theories Of The Third Kind" duration it decreases after every time I mark an episode as played. I never marked any played for this podcast though. The 3hr episode was for Joe Rogan, which didn't increase. And the 1hr episode was for 2 Bears, which does look like it increased accurately.

All options/filters are the same in all three screenshots.

@XilinJia
Copy link
Owner

I see. it appears having to do with the filter. Two things need to change:

  1. when a finite filter is set, the filter button should reflect
  2. when it's set to "All time", current code sets the max time to the time and persists it. it should be set to MAX_VALUE

@XilinJia
Copy link
Owner

Let me know how 8.11.1 works.

@toofyspooder
Copy link
Author

Looks like the duration for Theories increased but all other numbers have stayed the same after update. I was thinking the Joe Rogan duration would have increased by the 3hrs from that episode it is missing.

8.11.0
Image

8.11.1
Image

@XilinJia
Copy link
Owner

Hum. is your 3hr episode included in the episodes list in Statistics? Not sure how to reproduce the situation. Can you outline a simple reproducible procedure?

@toofyspooder
Copy link
Author

The episode is listed in there as played/marked played. It's weird, now the durations are all different after upgrading to 8.11.4 but the spent is still the same? I don't know if it's just me seeing these numbers change?

@XilinJia
Copy link
Owner

The 3-hour episode, did you do something first (like removing it from queue) that caused it to be marked Skipped, then you marked it as Played? So before you marked it as Played, its full duration was already counted (as it was Skipped), then when you marked it Played, you would see no change in total duration.

@toofyspooder
Copy link
Author

So if an episode is set to skip, then I mark it as played, it won't could towards the stats? I have downloaded episodes before and then listened to them on my computer. So I removed the download in Podcini which sets the episode to skipped. Then I mark it as played.

If marking it as played doesn't make it count to stats, and the original skipped status is the one it uses then that would be the case.

@XilinJia
Copy link
Owner

When an episode is marked as Skipped, its total duration is counted in statistics. Then when you mark it to Played, the same duration is counted, so nothing will change then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants