Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: Add documentation for x-amz-content-sha256 header #447

Open
msmoiz opened this issue Jun 27, 2024 · 1 comment
Open

AWS: Add documentation for x-amz-content-sha256 header #447

msmoiz opened this issue Jun 27, 2024 · 1 comment

Comments

@msmoiz
Copy link

msmoiz commented Jun 27, 2024

Thanks for creating this! It would be great to see documentation for the x-amz-content-sha256 header in the AWS signer docs. It seems this field needs to be set manually for an empty body (and perhaps in other cases) and this is not evident from the main example in the README or elsewhere. My original assumption was that this header would be set by the signer, and it took some time to figure out that I needed to set it myself.

@Xuanwo
Copy link
Owner

Xuanwo commented Jun 27, 2024

Thanks for raising this issue.

We require users to calculate and set the x-amz-content-sha256 to prevent reading the entire body for each request signature. This should be clearly stated in the documentation.

Would you like to initiate a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants