Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global.css 不要な部分を修正 #32

Closed
2 tasks done
dorimu0 opened this issue Feb 19, 2024 · 0 comments
Closed
2 tasks done

global.css 不要な部分を修正 #32

dorimu0 opened this issue Feb 19, 2024 · 0 comments
Assignees
@dorimu0
Labels
🎨 Html&css 마크업 & 스타일링 ⏰ P3 추가적인 의견 제시나 소소한 개선사항

Comments

@dorimu0
Copy link
Contributor

dorimu0 commented Feb 19, 2024 •
edited
Loading

📝 Issueの概要

このイシューの目的は、現在提供していないdarkmodeを除いて、全体のcssを合わせるためです。

📚 背景情報

現在、global.css にはdarkmodeを提供するためのcssが書かれていますが、現時点ではdarkmodeを提供していないので不要だと思います。 また、root cssを合わせる必要があると考えています。

📋 具体的な作業内容

  1. darkmodeのコメント
  2. root css 修正

📎 関連するIssueやドキュメント

なし

🖼️ 参考スクリーンショットや図

なし

🔄 Issueの進行状況

  • darkmodeのコメント
  • root css 色の修正
@dorimu0 dorimu0 added 🎨 Html&css 마크업 & 스타일링 ⏰ P3 추가적인 의견 제시나 소소한 개선사항 labels Feb 19, 2024
@dorimu0 dorimu0 self-assigned this Feb 19, 2024
dorimu0 added a commit to dorimu0/project_minori-next-deployment-repo that referenced this issue Feb 19, 2024
@dorimu0
💄 style : Modify root style in global.css
b3ecbe7 
- Unify the root css background to white
- We don't have plans to offer a dark mode at this time, so this will be a future fix.

Related issue: YJU-OKURA#32
@dorimu0 dorimu0 mentioned this issue Feb 19, 2024
Merged
@dorimu0 dorimu0 closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dorimu0 dorimu0

Labels
🎨 Html&css 마크업 & 스타일링 ⏰ P3 추가적인 의견 제시나 소소한 개선사항
Projects
ミノリ
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dorimu0