Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card Componentのレイアウト作成 #59

Closed
3 tasks done
Lainari opened this issue Feb 27, 2024 · 0 comments
Closed
3 tasks done

Card Componentのレイアウト作成 #59

Lainari opened this issue Feb 27, 2024 · 0 comments
Assignees
@Lainari
Labels
🎨 Html&css 마크업 & 스타일링 ⏰ P2 활발하게 고려해야 하는 이슈나 개선사항

Comments

@Lainari
Copy link
Collaborator

Lainari commented Feb 27, 2024 •
edited
Loading

📝 Issueの概要

  • グループ管理ページで共通に使用される要素をコンポーネント化します。

📚 背景情報

  • グループリスト要素のコードが重複しており、これを減らすためにコンポーネント化が必要です。

📋 具体的な作業内容

  1. 重複するコードのComponent化
  2. 別々に動作するCard Componentの区分
  3. グループリスト各ページに適用

📎 関連するIssueやTrello、ドキュメント

🖼️ 参考スクリーンショットや図

  • なし

🔄 Issueの進行状況

  • 重複するコードのComponent化
  • 別々に動作するCard Componentの区分
  • グループリスト各ページに適用
@Lainari Lainari added 🎨 Html&css 마크업 & 스타일링 ⏰ P2 활발하게 고려해야 하는 이슈나 개선사항 labels Feb 27, 2024
@Lainari Lainari self-assigned this Feb 27, 2024
@Lainari Lainari moved this to In progress in ミノリ Feb 27, 2024
Lainari added a commit to Lainari/project_minori-next-deployment-repo that referenced this issue Feb 27, 2024
@Lainari
✨ feat : Create a Card Component Layout
7761834 
- Make duplicate code into components for easier reuse
- Add interface files to apply the required types to each component

Related issue: YJU-OKURA#59
Lainari added a commit to Lainari/project_minori-next-deployment-repo that referenced this issue Feb 27, 2024
@Lainari
✨ feat : Applying the Card Component
1ef331a 
- When applied to the page where the component will be used

Related issue: YJU-OKURA#59
Lainari added a commit to Lainari/project_minori-next-deployment-repo that referenced this issue Feb 27, 2024
@Lainari
💄 style : Add images & icons to put in Card Components
6c775f8 
- Add example images and icons as png and svg files

Related issue: YJU-OKURA#59
@Lainari Lainari moved this from In progress to In review in ミノリ Feb 27, 2024
@Lainari Lainari mentioned this issue Feb 27, 2024
Merged
@Lainari Lainari moved this from In review to Done in ミノリ Feb 27, 2024
@Lainari Lainari closed this as completed Feb 27, 2024
Lainari added a commit to Lainari/project_minori-next-deployment-repo that referenced this issue Apr 21, 2024
@Lainari
♻️ refactor : Remove duplicate code from the card component
4cc5b2c 
- Unify card components that maintain the same style
- Manage many props at once with interface files

Related Issue : YJU-OKURA#59
Lainari added a commit to Lainari/project_minori-next-deployment-repo that referenced this issue May 8, 2024
@Lainari
♻️ refactor : Modify the layout used on the class list and class main…
76d09aa 
… page

- Change user's information to be passed in as props as well

Related Issue : YJU-OKURA#59 YJU-OKURA#77 YJU-OKURA#101
Lainari added a commit to Lainari/project_minori-next-deployment-repo that referenced this issue May 8, 2024
@Lainari
♻️ refactor : Modifying interfaces used in a class
f40e27c 
- Change the paths of images used in a class

Related Issue : YJU-OKURA#59 YJU-OKURA#77 YJU-OKURA#101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lainari Lainari

Labels
🎨 Html&css 마크업 & 스타일링 ⏰ P2 활발하게 고려해야 하는 이슈나 개선사항
Projects
ミノリ
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Lainari