Skip to content

Commit 21feb4b

Browse files
committed
Merge pull request puppetlabs#488 from cyberious/master
(maint) Fix test to not assume is_pe fact on > 4.0.0 puppet
2 parents 1282649 + 78e8c73 commit 21feb4b

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

spec/acceptance/fqdn_rand_string_spec.rb

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
describe 'fqdn_rand_string function', :unless => UNSUPPORTED_PLATFORMS.include?(fact('operatingsystem')) do
55
describe 'success' do
66
let(:facts_d) do
7-
if fact('is_pe', '--puppet') == "true"
7+
puppet_version = (on default, puppet('--version')).output.chomp
8+
if puppet_version < '4.0.0' && fact('is_pe', '--puppet') == "true"
89
if fact('osfamily') =~ /windows/i
910
if fact('kernelmajversion').to_f < 6.0
1011
'c:/documents and settings/all users/application data/puppetlabs/facter/facts.d'

spec/acceptance/fqdn_rotate_spec.rb

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
describe 'fqdn_rotate function', :unless => UNSUPPORTED_PLATFORMS.include?(fact('operatingsystem')) do
55
describe 'success' do
66
let(:facts_d) do
7-
if fact('is_pe', '--puppet') == "true"
7+
puppet_version = (on default, puppet('--version')).output.chomp
8+
if puppet_version < '4.0.0' && fact('is_pe', '--puppet') == "true"
89
if fact('osfamily') =~ /windows/i
910
if fact('kernelmajversion').to_f < 6.0
1011
'C:/Documents and Settings/All Users/Application Data/PuppetLabs/facter/facts.d'

0 commit comments

Comments
 (0)