-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ihm.pkl files differ and lot of missing values in an episode #139
Comments
Hi Siva, Since the code hasn't been updated for a while it might be that some things don't work as expected with new versions of libraries. Have your tried using the exact versions of libraries specified in the
Unfortunately, we wrote code only for 17 variables. |
Hey Hrayr, thanks for replying. I get the following warning when running the validate_events script:
Okay. Also, I'd like to know the rationale behind choosing the impute values, as mentioned in table 3 of the paper. |
Hi Siva, Unfortunately, the tests I wrote before are too rigid and detect even insignificant differences. The current version of the code does not pass those tests, but I have verified manually that all the produced csv files match with those generated by older and tested versions of the code. I am currently trying to write better tests.
Most episodes have a lot of missing data. But if you suspect that any particular csv file is incorrect, please paste here, I will verify with the local version.
I get that warning too. It has no effect, don't worry about it. |
I'll wait for the updated tests, thank you.
Will paste one soon, just to be sure. |
Hi Siva, I have updated the tests. They are still not ideal, but you should get the same results if you follow the exact installation and benchmark building instructions of |
Hi Hrayr, Can you please comment on this? Thanks in advance. |
After creating the benchmark dataset for in-hospital-mortality risk, the ihm.pkl files differ when the test for checking is run.
Also the csv's for each episode have lot of missing values at each time stamp, for example capillary refill rate, always has no value, is this a norm?
Is there something I'm doing wrong while building the dataset, please let me know, thank you.
PS: Is there any possibility of getting the updated library with 50+ variables as mentioned previously?
The text was updated successfully, but these errors were encountered: