Move COSE_Key_Ref and two-party alg definitions to separate spec #32
+27
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlun
force-pushed
the
external-cose-key-ref
branch
from
ffb58d6 to
d8c0425
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are moved to: https://github.com/YubicoLabs/cose-two-party-signing-algs-rfc
I chose to keep the definitions of the ARKG-pub and Ref-ARKG-derived types in this document since they are intrinsically linked to ARKG and do not depend on the two-party signing alg IDs. The algorithm registrations, however, do belong better in the other spec since they are specifically about defining how to generate a signature and are entirely irrelevant to signature verifiers.
I also want to change the definition of the
algparameter in the ARKG-pub type, as the current definition is unconventional and confusing:Rather I think
alg(3), if present, should represent the ARKG instance of the public seed (for which we currently define no alg IDs, so it cannot be used), and the usage of derived keys should instead be represented by a new parameter if at all. But I'll leave that for a separate PR.