From e41d26839d92cdf74940a7e0ff075b099b1b5a2e Mon Sep 17 00:00:00 2001 From: Greg Pfeil Date: Wed, 19 Feb 2025 11:44:03 -0700 Subject: [PATCH 1/2] fix(ci): correct typo in GitHub workflow Introduced by #9257, but overlooked because the workflow runs asynchronously. (Is there a way to get GitHub to validate workflow files in a PR check, rather than only when the workflow runs?) --- .github/workflows/chore-delete-gcp-resources.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/chore-delete-gcp-resources.yml b/.github/workflows/chore-delete-gcp-resources.yml index 92d9103480b..e611498fdb2 100644 --- a/.github/workflows/chore-delete-gcp-resources.yml +++ b/.github/workflows/chore-delete-gcp-resources.yml @@ -106,7 +106,7 @@ jobs: # The same artifacts are used for both mainnet and testnet. clean-registries: name: Delete unused artifacts in registry - if: github.repository_owner == 'ZcashFoundation'' + if: github.repository_owner == 'ZcashFoundation' runs-on: ubuntu-latest permissions: contents: 'read' From 4950c33254f5d69f4e5fa99fe35e9772cc6acaa7 Mon Sep 17 00:00:00 2001 From: Greg Pfeil Date: Wed, 19 Feb 2025 12:07:10 -0700 Subject: [PATCH 2/2] =?UTF-8?q?Don=E2=80=99t=20allow=20CI=20to=20open=20is?= =?UTF-8?q?sues=20on=20forks?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Forks generally don’t have issues enabled, so jobs that try to create an issue will fail there. --- .github/workflows/ci-build-crates.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci-build-crates.yml b/.github/workflows/ci-build-crates.yml index 4498fdec2c9..e264676a136 100644 --- a/.github/workflows/ci-build-crates.yml +++ b/.github/workflows/ci-build-crates.yml @@ -170,7 +170,11 @@ jobs: needs: [ matrix, build ] # Only open tickets for failed or cancelled jobs that are not coming from PRs. # (PR statuses are already reported in the PR jobs list, and checked by GitHub's Merge Queue.) - if: (failure() && github.event.pull_request == null) || (cancelled() && github.event.pull_request == null) + # + # NB: This creates issues, so will fail on repos that have issues disabled (e.g., forks). + # Unfortunately, there doesn’t seem to be a GitHub property that says whether issues are + # enabled, so we check that the repo is in the ZcashFoundation org as a proxy. + if: (failure() || cancelled()) && github.repository_owner == 'ZcashFoundation' && github.event.pull_request == null runs-on: ubuntu-latest steps: - uses: jayqi/failed-build-issue-action@v1