fix: Allow custom icons in ZetaFilterSelection (#152)

ci: Update to latest version of flutter-code-quality action
chore: Remve support for deprecated buttonBarTheme in ThemeData

Author: thelukewalton

.github/workflows/pull-request.yml

@@ -21,7 +21,7 @@ jobs:
           with:
             cache: true
         - run: dart run build_runner build --delete-conflicting-outputs
-        - uses: ZebraDevs/[email protected].7
+        - uses: ZebraDevs/[email protected].8
           with:
             token: ${{secrets.GITHUB_TOKEN}}
 

example/macos/Runner/AppDelegate.swift

@@ -1,7 +1,7 @@
 import Cocoa
 import FlutterMacOS
 
-@NSApplicationMain
+@main
 class AppDelegate: FlutterAppDelegate {
   override func applicationShouldTerminateAfterLastWindowClosed(_ sender: NSApplication) -> Bool {
     return true

lib/src/components/filter_selection/filter_selection.dart

@@ -13,6 +13,7 @@ class ZetaFilterSelection extends ZetaStatelessWidget {
     required this.items,
     this.onPressed,
     this.buttonSemanticLabel,
+    this.icon = ZetaIcons.filter,
   });
 
   /// The filter items - list of [ZetaFilterChip].
@@ -26,6 +27,11 @@ class ZetaFilterSelection extends ZetaStatelessWidget {
   /// {@macro zeta-widget-semantic-label}
   final String? buttonSemanticLabel;
 
+  /// Icon for the filter button.
+  ///
+  /// Default is [ZetaIcons.filter].
+  final IconData icon;
+
   @override
   Widget build(BuildContext context) {
     return SizedBox(
@@ -43,10 +49,7 @@ class ZetaFilterSelection extends ZetaStatelessWidget {
               child: IconButton(
                 visualDensity: VisualDensity.compact,
                 onPressed: onPressed,
-                icon: const ZetaIcon(
-                  ZetaIcons.filter,
-                  size: ZetaSpacing.xl_2,
-                ),
+                icon: ZetaIcon(icon, size: ZetaSpacing.xl_2),
               ),
             ),
           ),
@@ -70,6 +73,7 @@ class ZetaFilterSelection extends ZetaStatelessWidget {
     properties
       ..add(DiagnosticsProperty<bool>('rounded', rounded))
       ..add(ObjectFlagProperty<VoidCallback?>.has('onPressed', onPressed))
-      ..add(StringProperty('buttonSemanticLabel', buttonSemanticLabel));
+      ..add(StringProperty('buttonSemanticLabel', buttonSemanticLabel))
+      ..add(DiagnosticsProperty<IconData>('icon', icon));
   }
 }

lib/src/utils/zeta_provider.dart

@@ -434,7 +434,6 @@ ThemeData generateZetaTheme({
       bottomAppBarTheme: existingTheme.bottomAppBarTheme,
       bottomNavigationBarTheme: existingTheme.bottomNavigationBarTheme,
       bottomSheetTheme: existingTheme.bottomSheetTheme,
-      buttonBarTheme: existingTheme.buttonBarTheme,
       buttonTheme: existingTheme.buttonTheme,
       cardTheme: existingTheme.cardTheme,
       checkboxTheme: existingTheme.checkboxTheme,