Skip to content

Commit 55a357d

Browse files
committed
Add some comments.
1 parent f7fbd3a commit 55a357d

File tree

4 files changed

+5
-0
lines changed

4 files changed

+5
-0
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
vendor/
22
node_modules/
33
build/
4+
phpcompat.zip

src/js/run.js

+2
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@ function checkStatus() {
7676

7777
var obj;
7878
jQuery.post( ajaxurl, data, function( obj ) {
79+
// TODO: Without jQuery migrate an empty response can throw a JSON parse error.
80+
// So we should do the parsing manually.
7981
if ( !obj ) {
8082
startTimer();
8183
return;

tests/qunit/index.html

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<div id="qunit-fixture"></div>
1212
<script src="https://code.jquery.com/qunit/qunit-2.0.0.js"></script>
1313
<script src="https://code.jquery.com/jquery-1.12.4.min.js"></script>
14+
<script src="https://code.jquery.com/jquery-migrate-1.4.1.js"></script>
1415
<script src="https://code.jquery.com/ui/1.11.4/jquery-ui.js"></script>
1516
<script src="https://cdn.jsdelivr.net/jquery.mockjax/2.2.0/jquery.mockjax.min.js"></script>
1617
<script src="../../src/js/handlebars.js"></script>

tests/qunit/test-run.js

+1
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ QUnit.test( 'Test checkStatus done', function( assert ) {
148148
checkStatus();
149149
});
150150

151+
// This happens when the test doesn't start before checkStatus is called.
151152
QUnit.test( 'Test checkStatus empty result', function( assert ) {
152153
var done = assert.async();
153154
var fixture = $( '#qunit-fixture' );

0 commit comments

Comments
 (0)