`clang-tidy` 17 and above break snippets

[sykhro]

clang 17 has increased the snippet lines from 1 to a maximum of 16
https://github.com/llvm/llvm-project/blob/6009708b4367171ccdbf4b5905cb6a803753fe18/clang/include/clang/Basic/DiagnosticOptions.h#L87

(introduced in llvm/llvm-project@f63155a)

This breaks the suggestions:

[sykhro]

The old behaviour can be restored by passing -fcaret-diagnostics-max-lines=1 -fdiagnostics-show-line-numbers=0

[ZedThree]

Ah, that's a pain! Thanks for the heads up. PRs very welcome :)

[sykhro]

I'm happy to contribute but the project is a bit hard to nagivate. Could you point me to where options are passed to clang-tidy? For now I can at least restore the old behaviour.

For the future, I would consider not parsing the output and switching to this tool which transforms the clang-tidy output to SARIF, a standard format for static analysis that should end up in clang too someday. The action can then act on that