Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor SPA #83

Open
coeit opened this issue Jan 20, 2021 · 0 comments
Open

refactor SPA #83

coeit opened this issue Jan 20, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@coeit
Copy link
Member

coeit commented Jan 20, 2021

Description

Problems

Generating code for the single page application creates a very large number of React components.
Generated components are often too large in size, integrate complex logic, and deal with multiple concerns.

Hypotheses

  • Many components are exact duplicates; these could be made static (i.e. not generated) and reused by the components that do require generation.
  • Many generated components are highly similar; much of their logic and markup could be extracted into templates that are reused via props.
  • Large components include complex logic that spans multiple concerns; these components could be refactored into multiple, single-responsibility sub-components.
  • Much of the logic within components is generated via ejs templating, causing code duplication; this can be avoided by extracting this logic into utility functions that can be reused.

Resources

For documentation of this issue see gitbook

@coeit coeit added the enhancement New feature or request label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants