remove sentinel trait

Author: SizzinSeal

include/common/result.hpp

@@ -45,11 +45,11 @@ class Result {
      * @param error Error to store.
      * @note Requires T to have a defined sentinel value (via SentinelValue<T>).
      */
-    template<traits::IsResultError E>
-        requires traits::InPack<E, Errs...>
-    constexpr Result(E&& error)
+    template<typename U, traits::IsResultError E>
+        requires std::convertible_to<U, T> && traits::InPack<E, Errs...>
+    constexpr Result(E&& error, U&& value)
         : error(std::forward<E>(error)),
-          value(traits::sentinel_v<T>) {}
+          value(std::forward<U>(value)) {}
 
     /**
      * @brief Get the error of the given type, wrapped in std::optional

include/common/result_impl.hpp

@@ -2,7 +2,6 @@
 
 #include <chrono>
 #include <concepts>
-#include <limits>
 #include <stacktrace>
 #include <variant> // IWYU pragma: keep (std::get is used, not sure why clangd says this header isn't needed)
 
@@ -103,30 +102,6 @@ concept AllUnique = ([]<typename U>(std::type_identity<U>) {
 template<typename T>
 concept IsResultError = std::is_base_of_v<ResultError, std::remove_cvref_t<T>>;
 
-/**
- * @brief Get the defined sentinel value for a given type.
- *
- * @tparam T
- */
-template<typename T>
-inline constexpr T sentinel_v;
-
-template<std::integral T>
-inline constexpr T sentinel_v<T> = std::numeric_limits<T>::max();
-
-template<std::floating_point T>
-inline constexpr T sentinel_v<T> =
-    std::numeric_limits<T>::has_infinity ? std::numeric_limits<T>::infinity()
-                                         : std::numeric_limits<T>::max();
-
-/**
- * @brief Concept to check if a type has a defined sentinel value.
- *
- * @tparam T Type to check.
- */
-template<typename T>
-concept HasSentinel = requires(T) { sentinel_v<T>; };
-
 /**
  * @brief Check whether a given type is in a typename pack
  *